feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use unique_ptr in KitManager

Browse Source 
Use unique_ptr to manage m_writer in KitManagerPrivate.

Change-Id: Icc58728feb57a88a229d6da8b2d29bac53c2f6cc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tobias Hunger
2018-07-16 14:09:50 +02:00
parent 80c2ce118d
commit 61e93455aa
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -73,14 +73,13 @@ public:
bool m_initialized = false; bool m_initialized = false;
std::vector<std::unique_ptr<KitInformation>> m_informationList; std::vector<std::unique_ptr<KitInformation>> m_informationList;
QList<Kit *> m_kitList; QList<Kit *> m_kitList;
PersistentSettingsWriter *m_writer = nullptr; std::unique_ptr<PersistentSettingsWriter> m_writer;
}; };
KitManagerPrivate::~KitManagerPrivate() KitManagerPrivate::~KitManagerPrivate()
{ {
foreach (Kit *k, m_kitList) foreach (Kit *k, m_kitList)
delete k; delete k;
delete m_writer;
} }
} // namespace Internal } // namespace Internal
@@ -192,7 +191,7 @@ void KitManager::restoreKits()
std::swap(resultList, d->m_kitList); std::swap(resultList, d->m_kitList);
setDefaultKit(k); setDefaultKit(k);
d->m_writer = new PersistentSettingsWriter(settingsFileName(), "QtCreatorProfiles"); d->m_writer = std::make_unique<PersistentSettingsWriter>(settingsFileName(), "QtCreatorProfiles");
d->m_initialized = true; d->m_initialized = true;
emit kitsLoaded(); emit kitsLoaded();
emit kitsChanged(); emit kitsChanged();