From 61fcdcb4a150ec08968d935be2dc6c2009b7dd8a Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Sat, 19 Nov 2022 12:33:23 +0100 Subject: [PATCH] CMakePM: Do not crash with invalid build presets If a build preset doensn't reference a configurePreset, the preset is invalid but Qt Creator crashes. Task-number: QTCREATORBUG-24555 Change-Id: Ibf5dd7f1bb165d8b7f392e6a1aaa043548bb0f7a Reviewed-by: Reviewed-by: Cristian Adam --- src/plugins/cmakeprojectmanager/cmakeproject.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmakeproject.cpp b/src/plugins/cmakeprojectmanager/cmakeproject.cpp index 8be9be049e9..ad4c685d3f5 100644 --- a/src/plugins/cmakeprojectmanager/cmakeproject.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeproject.cpp @@ -163,7 +163,7 @@ void CMakeProject::setupBuildPresets(Internal::PresetsData &presetsData) TaskHub::requestPopup(); } - const QString &configurePresetName = buildPreset.configurePreset.value(); + const QString &configurePresetName = buildPreset.configurePreset.value_or(QString()); buildPreset.environment = Utils::findOrDefault(presetsData.configurePresets, [configurePresetName](