feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Add a soft assertion

Browse Source 
If directory is empty, buttons remains NULL, which leads to a crash

To reproduce, open Branches dialog then close all editors
and projects and click Log for a branch

Change-Id: Icf06b76c58585c0dd6062017e94e07dad016c275
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Orgad Shaneh
2013-06-28 17:28:40 +03:00
committed by Orgad Shaneh
parent e6c85d5ff9
commit 62554e7647
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/git/gitclient.cpp
View File

@@ -632,6 +632,7 @@ public:
m_enableAnnotationContextMenu(enableAnnotationContextMenu), m_enableAnnotationContextMenu(enableAnnotationContextMenu),
m_fileNames(fileNames) m_fileNames(fileNames)
{ {
QTC_ASSERT(!directory.isEmpty(), return);
QToolButton *diffButton = addToggleButton(QLatin1String("--patch"), tr("Show Diff"), QToolButton *diffButton = addToggleButton(QLatin1String("--patch"), tr("Show Diff"),
tr("Show difference.")); tr("Show difference."));
mapSetting(diffButton, m_client->settings()->boolPointer(GitSettings::logDiffKey)); mapSetting(diffButton, m_client->settings()->boolPointer(GitSettings::logDiffKey));