diff --git a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp index 06e57930ec1..26cb96422ec 100644 --- a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp +++ b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp @@ -1140,7 +1140,7 @@ static inline void setAdjustedPos(const QmlDesigner::ModelNode &modelNode) void reparentToNodeAndAdjustPosition(const ModelNode &parentModelNode, const QList &modelNodeList) { - for (ModelNode modelNode : modelNodeList) { + for (const ModelNode &modelNode : modelNodeList) { reparentTo(modelNode, parentModelNode); setAdjustedPos(modelNode); diff --git a/src/plugins/qmldesigner/components/componentcore/theme.cpp b/src/plugins/qmldesigner/components/componentcore/theme.cpp index 29b937a502a..74c53841bdf 100644 --- a/src/plugins/qmldesigner/components/componentcore/theme.cpp +++ b/src/plugins/qmldesigner/components/componentcore/theme.cpp @@ -61,7 +61,7 @@ Theme::Theme(Utils::Theme *originTheme, QObject *parent) else if (component.status() == QQmlComponent::Error ) { qCWarning(themeLog) << "Couldn't load" << constantsPath << "due to the following error(s):"; - for (QQmlError error : component.errors()) + for (const QQmlError &error : component.errors()) qCWarning(themeLog) << error.toString(); } else { diff --git a/src/plugins/qmldesigner/components/curveeditor/detail/curveitem.cpp b/src/plugins/qmldesigner/components/curveeditor/detail/curveitem.cpp index e8dd1685804..e9f994214ed 100644 --- a/src/plugins/qmldesigner/components/curveeditor/detail/curveitem.cpp +++ b/src/plugins/qmldesigner/components/curveeditor/detail/curveitem.cpp @@ -336,7 +336,7 @@ void CurveItem::setCurve(const AnimationCurve &curve) { freeClear(m_keyframes); - for (auto frame : curve.keyframes()) { + for (const auto &frame : curve.keyframes()) { auto *item = new KeyframeItem(frame, this); item->setLocked(locked()); item->setComponentTransform(m_transform); diff --git a/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp b/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp index 946a3e72e79..b615dc06486 100644 --- a/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp +++ b/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp @@ -781,7 +781,7 @@ public: } if (from.empty()) { - for (const ModelNode wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) { + for (const ModelNode &wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) { if (wildcard.bindingProperty("target").resolveToModelNode() == node.modelNode()) { from.clear(); from.append(wildcard); diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp index 0beb5bce729..62999ba193e 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp @@ -125,7 +125,7 @@ ItemLibraryAssetImportDialog::ItemLibraryAssetImportDialog(const QStringList &im QString candidatePath = targetDir + defaultAssetFolder + quick3DFolder; int candidatePriority = 5; - for (auto importPath : qAsConst(importPaths)) { + for (const auto &importPath : qAsConst(importPaths)) { if (importPath.startsWith(targetDir)) { const bool isDefaultFolder = importPath.endsWith(defaultAssetFolder); const QString assetFolder = importPath + quick3DFolder; diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibrarymodel.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibrarymodel.cpp index 57f0d7ee944..3c03e86c617 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibrarymodel.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibrarymodel.cpp @@ -294,7 +294,7 @@ void ItemLibraryModel::sortSections() std::sort(m_sections.begin(), m_sections.end(), sectionSort); - for (auto itemLibrarySection : m_sections) + for (const auto itemLibrarySection : m_sections) itemLibrarySection->sortItems(); } diff --git a/src/plugins/qmldesigner/components/itemlibrary/itemlibrarysection.cpp b/src/plugins/qmldesigner/components/itemlibrary/itemlibrarysection.cpp index b1db4d128e5..fcdcfba3872 100644 --- a/src/plugins/qmldesigner/components/itemlibrary/itemlibrarysection.cpp +++ b/src/plugins/qmldesigner/components/itemlibrary/itemlibrarysection.cpp @@ -74,7 +74,7 @@ bool ItemLibrarySection::updateSectionVisibility(const QString &searchText, bool *changed = false; - for (auto itemLibraryItem : m_sectionEntries.items()) { + for (const auto itemLibraryItem : m_sectionEntries.items()) { bool itemVisible = itemLibraryItem->itemName().toLower().contains(searchText) || itemLibraryItem->typeName().toLower().contains(searchText); diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelineactions.cpp b/src/plugins/qmldesigner/components/timelineeditor/timelineactions.cpp index 4d2523b3a37..c9271e490c9 100644 --- a/src/plugins/qmldesigner/components/timelineeditor/timelineactions.cpp +++ b/src/plugins/qmldesigner/components/timelineeditor/timelineactions.cpp @@ -252,7 +252,7 @@ std::vector> getFramesRelative(const ModelNode &par if (!sortedByTime.empty()) { qreal firstTime = getTime(sortedByTime.first()); - for (ModelNode keyframe : sortedByTime) + for (const ModelNode &keyframe : sortedByTime) result.emplace_back(keyframe, getTime(keyframe) - firstTime); } diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp b/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp index d8d34fe1d11..7e8bfb6f505 100644 --- a/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp +++ b/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp @@ -209,7 +209,7 @@ ModelNode TimelineSectionItem::targetNode() const QVector TimelineSectionItem::keyframePositions() const { QVector out; - for (auto frame : m_timeline.keyframeGroupsForTarget(m_targetNode)) + for (const auto &frame : m_timeline.keyframeGroupsForTarget(m_targetNode)) out.append(timelineScene()->keyframePositions(frame)); return out; diff --git a/src/plugins/qmldesigner/designercore/model/stylesheetmerger.cpp b/src/plugins/qmldesigner/designercore/model/stylesheetmerger.cpp index b54d39ef066..52cf0f2ba14 100644 --- a/src/plugins/qmldesigner/designercore/model/stylesheetmerger.cpp +++ b/src/plugins/qmldesigner/designercore/model/stylesheetmerger.cpp @@ -212,7 +212,7 @@ void StylesheetMerger::preprocessStyleSheet() { try { RewriterTransaction transaction(m_styleView, "preprocess-stylesheet"); - for (ModelNode currentStyleNode : m_styleView->rootModelNode().directSubModelNodes()) { + for (const ModelNode ¤tStyleNode : m_styleView->rootModelNode().directSubModelNodes()) { QString id = currentStyleNode.id(); if (!idExistsInBothModels(id)) @@ -277,7 +277,7 @@ void StylesheetMerger::replaceNode(ModelNode &replacedNode, ModelNode &newNode) bool isNodeProperty = false; PropertyName reparentName; - for (NodeProperty prop : parentModelNode.nodeProperties()) { + for (const NodeProperty &prop : parentModelNode.nodeProperties()) { if (prop.modelNode().id() == replacedNode.id()) { isNodeProperty = true; reparentName = prop.name(); @@ -441,13 +441,13 @@ void StylesheetMerger::merge() replacementNodes.enqueue(styleRootNode); } // otherwise, the nodes to replace are the direct sub nodes of the style sheet's root - for (ModelNode subNode : styleRootNode.allSubModelNodes()) { + for (const ModelNode &subNode : styleRootNode.allSubModelNodes()) { if (m_templateView->hasId(subNode.id())) { replacementNodes.enqueue(subNode); } } - for (ModelNode currentNode : replacementNodes) { + for (const ModelNode ¤tNode : replacementNodes) { bool hasPos = false; diff --git a/src/plugins/qmldesigner/designercore/model/viewmanager.cpp b/src/plugins/qmldesigner/designercore/model/viewmanager.cpp index 3173a68abd7..00536abb0a0 100644 --- a/src/plugins/qmldesigner/designercore/model/viewmanager.cpp +++ b/src/plugins/qmldesigner/designercore/model/viewmanager.cpp @@ -238,7 +238,7 @@ void ViewManager::detachAdditionalViews() void ViewManager::detachStandardViews() { - for (auto view : standardViews()) { + for (const auto view : standardViews()) { if (view->isAttached()) currentModel()->detachView(view); } @@ -280,7 +280,7 @@ void ViewManager::attachViewsExceptRewriterAndComponetView() int last = time.elapsed(); int currentTime = 0; if (!d->disableStandardViews) { - for (auto view : standardViews()) { + for (const auto view : standardViews()) { currentModel()->attachView(view); currentTime = time.elapsed(); qCInfo(viewBenchmark) << view->widgetInfo().uniqueId << currentTime - last; diff --git a/src/plugins/qmldesigner/generateresource.cpp b/src/plugins/qmldesigner/generateresource.cpp index 87e9772ab4a..57661f0aa48 100644 --- a/src/plugins/qmldesigner/generateresource.cpp +++ b/src/plugins/qmldesigner/generateresource.cpp @@ -108,7 +108,7 @@ void GenerateResource::generateMenuEntry() const QStringList arguments1 = {"--project", "--output", temp.fileName()}; const QStringList arguments2 = {"--binary", "--output", resourceFileName, temp.fileName()}; - for (auto arguments : {arguments1, arguments2}) { + for (const auto &arguments : {arguments1, arguments2}) { rccProcess.start(rccBinary.toString(), arguments); if (!rccProcess.waitForStarted()) { Core::MessageManager::write(QCoreApplication::translate("QmlDesigner::GenerateResource", diff --git a/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp b/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp index 1fe99825c37..ff63f6522c5 100644 --- a/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp +++ b/src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp @@ -144,7 +144,7 @@ void FpsLabelAction::fpsHandler(quint16 fpsValues[8]) fpsText = fpsText.arg("--"); else fpsText = fpsText.arg(lastValidFrames); - for (QPointer label : fpsHandlerLabelList) { + for (const QPointer label : fpsHandlerLabelList) { if (label) label->setText(fpsText); }