diff --git a/src/plugins/cmakeprojectmanager/cmakeformatter.cpp b/src/plugins/cmakeprojectmanager/cmakeformatter.cpp
index dca6d47e203..8a727ba7942 100644
--- a/src/plugins/cmakeprojectmanager/cmakeformatter.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakeformatter.cpp
@@ -60,10 +60,12 @@ public:
autoFormatOnlyCurrentProject.setSettingsKey("autoFormatOnlyCurrentProject");
autoFormatOnlyCurrentProject.setDefaultValue(true);
autoFormatOnlyCurrentProject.setLabelText(Tr::tr("Restrict to files contained in the current project"));
+ autoFormatOnlyCurrentProject.setLabelPlacement(BoolAspect::LabelPlacement::AtCheckBox);
autoFormatMime.setSettingsKey("autoFormatMime");
autoFormatMime.setDefaultValue("text/x-cmake");
autoFormatMime.setLabelText(Tr::tr("Restrict to MIME types:"));
+ autoFormatMime.setDisplayStyle(StringAspect::LineEditDisplay);
setLayouter([this] {
using namespace Layouting;
@@ -73,9 +75,12 @@ public:
Group {
title(Tr::tr("Automatic Formatting on File Save")),
autoFormatOnSave.groupChecker(),
- Form {
- autoFormatMime, br,
- Span(2, autoFormatOnlyCurrentProject)
+ // Conceptually, that's a Form, but this would look odd:
+ // xxxxxx [____]
+ // [x] xxxxxxxxxxxxxx
+ Column {
+ Row { autoFormatMime },
+ autoFormatOnlyCurrentProject
}
},
st
diff --git a/tests/system/shared/utils.py b/tests/system/shared/utils.py
index 6b99c8959da..2a17e0333c2 100644
--- a/tests/system/shared/utils.py
+++ b/tests/system/shared/utils.py
@@ -171,6 +171,10 @@ def invokeMenuItem(menu, item, *subItems):
numberedPrefix = "%d | "
for subItem in subItems:
# we might have numbered sub items (e.g. "Recent Files") - these have this special prefix
+ # but on macOS we don't add these prefixes
+ if platform.system() == 'Darwin' and subItem.startswith(numberedPrefix):
+ subItem = subItem[5:]
+
if subItem.startswith(numberedPrefix):
triggered = False
for i in range(1, 10):
@@ -186,7 +190,10 @@ def invokeMenuItem(menu, item, *subItems):
"Function arguments: '%s', '%s', %s" % (menu, item, str(subItems)))
break # we failed to trigger - no need to process subItems further
else:
+ noAmpersandItem = item.replace('&', '')
+ waitForObject("{type='QMenu' title='%s'}" % noAmpersandItem, 2000)
itemObject = waitForObjectItem(itemObject, subItem)
+ waitFor("itemObject.enabled", 2000)
activateItem(itemObject)
diff --git a/tests/system/suite_editors/tst_edit_externally/test.py b/tests/system/suite_editors/tst_edit_externally/test.py
index b468b4ebe04..dea2f5d8ec6 100644
--- a/tests/system/suite_editors/tst_edit_externally/test.py
+++ b/tests/system/suite_editors/tst_edit_externally/test.py
@@ -26,7 +26,8 @@ def main():
mBox = ("{text?='The file * has been changed on disk. Do you want to reload it?' "
"type='QMessageBox' unnamed='1' visible='1'}")
popupText = ("The file %s has been changed on disk. Do you want to reload it?
"
- "The default behavior can be set in Edit > Preferences > Environment > System.
")
+ "The default behavior can be set in X > Preferences > Environment > System.
")
+ popupText = popupText.replace("X", "Qt Creator" if platform.system() == "Darwin" else "Edit")
formerContent = None
for i, currentFile in enumerate(files):
diff --git a/tests/system/suite_general/tst_default_settings/test.py b/tests/system/suite_general/tst_default_settings/test.py
index b1bf0b36d55..ce026e98d36 100644
--- a/tests/system/suite_general/tst_default_settings/test.py
+++ b/tests/system/suite_general/tst_default_settings/test.py
@@ -318,8 +318,8 @@ def __compareCompilers__(foundCompilers, expectedCompilers):
isRegex = ".*?" in key or "[.0-9]+" in key
if (((isRegex and re.match(key, list(currentFound.keys())[0], flags)))
or currentFound.keys() == currentExp.keys()):
- if ((isWin and os.path.abspath(currentFound.values()[0].lower())
- == os.path.abspath(currentExp.values()[0].lower()))
+ if ((isWin and os.path.abspath(list(currentFound.values())[0].lower())
+ == os.path.abspath(list(currentExp.values())[0].lower()))
or currentFound.values() == currentExp.values()):
foundExp = True
break