forked from qt-creator/qt-creator
Stop build on fatal make errors
... ignoring a error code of 0 from Make. This is necessary to detect build failures on symbian Do not show errors when ignoring the return value of a BuildStep either. Task-number: QTCREATORBUG-985 Reviewed-by: dt
This commit is contained in:
@@ -187,6 +187,16 @@ void MakeStep::run(QFutureInterface<bool> & fi)
|
||||
AbstractProcessStep::run(fi);
|
||||
}
|
||||
|
||||
bool MakeStep::processSucceeded(int exitCode, QProcess::ExitStatus status)
|
||||
{
|
||||
// Symbian does retun 0, even on failed makes! So we check for fatal make errors here.
|
||||
ProjectExplorer::GnuMakeParser *parser = qobject_cast<ProjectExplorer::GnuMakeParser *>(outputParser());
|
||||
if (parser && parser->fatalErrors() != 0)
|
||||
return false;
|
||||
|
||||
return AbstractProcessStep::processSucceeded(exitCode, status);
|
||||
}
|
||||
|
||||
bool MakeStep::immutable() const
|
||||
{
|
||||
return false;
|
||||
|
||||
Reference in New Issue
Block a user