feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Constify ContainerAspect::forEachAspect

Browse Source 
It doesn't modify the container itself.

Change-Id: Ia98da2488398fd7605b2b113b3aa6dfb882ab892
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2021-03-01 08:53:36 +01:00
parent 0f5b6c82ee
commit 632993a9b2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/utils/aspects.cpp
View File

@@ -1857,7 +1857,7 @@ void AspectContainer::finish()
aspect->finish(); aspect->finish();
} }
void AspectContainer::forEachAspect(const std::function<void(BaseAspect *)> &run) void AspectContainer::forEachAspect(const std::function<void(BaseAspect *)> &run) const
{ {
for (BaseAspect *aspect : qAsConst(d->m_items)) { for (BaseAspect *aspect : qAsConst(d->m_items)) {
if (auto container = dynamic_cast<AspectContainer *>(aspect)) if (auto container = dynamic_cast<AspectContainer *>(aspect))

2
src/libs/utils/aspects.h
View File

@@ -478,7 +478,7 @@ public:
void cancel() override; void cancel() override;
void finish() override; void finish() override;
void forEachAspect(const std::function<void(BaseAspect *)> &run); void forEachAspect(const std::function<void(BaseAspect *)> &run) const;
private: private:
std::unique_ptr<Internal::AspectContainerPrivate> d; std::unique_ptr<Internal::AspectContainerPrivate> d;