From 635e7465719d5b62cffb96d775298367d170adb2 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Mon, 16 Sep 2024 12:36:40 +0200
Subject: [PATCH] ProjectExplorer: Take bundle completeness into account

... when finding the most suitable toolchain.

Fixes: QTCREATORBUG-31565
Change-Id: Ie5abeb5863713e6350ec654706bd1b6b86fced7f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 src/plugins/projectexplorer/toolchainmanager.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/plugins/projectexplorer/toolchainmanager.cpp b/src/plugins/projectexplorer/toolchainmanager.cpp
index 91379fffa95..8e59ec7a505 100644
--- a/src/plugins/projectexplorer/toolchainmanager.cpp
+++ b/src/plugins/projectexplorer/toolchainmanager.cpp
@@ -339,6 +339,11 @@ void ToolchainManager::addBadToolchain(const Utils::FilePath &toolchain)
 bool ToolchainManager::isBetterToolchain(
     const ToolchainBundle &bundle1, const ToolchainBundle &bundle2)
 {
+    if (const ToolchainBundle::Valid valid1 = bundle1.validity(), valid2 = bundle2.validity();
+        valid1 != valid2) {
+        return valid1 == ToolchainBundle::Valid::All || valid2 == ToolchainBundle::Valid::None;
+    }
+
     const int priority1 = bundle1.get(&Toolchain::priority);
     const int priority2 = bundle2.get(&Toolchain::priority);
     if (priority1 > priority2)