From 6384ce6d4ad1396754827cc26c718df4532627a9 Mon Sep 17 00:00:00 2001
From: Orgad Shaneh <orgad.shaneh@audiocodes.com>
Date: Sun, 3 Nov 2024 10:05:28 +0200
Subject: [PATCH] Id: Remove redundant const modifiers from by-value arguments

Change-Id: I2f66822b8b8076ed2eb13729bd466e9e2204bccb
Reviewed-by: hjk <hjk@qt.io>
---
 src/libs/utils/id.cpp | 8 ++++----
 src/libs/utils/id.h   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/libs/utils/id.cpp b/src/libs/utils/id.cpp
index 59bebb746cb..0ff3fd2ed84 100644
--- a/src/libs/utils/id.cpp
+++ b/src/libs/utils/id.cpp
@@ -183,7 +183,7 @@ Key Id::toKey() const
   \sa toString(), fromSetting()
 */
 
-Id Id::fromString(const QStringView name)
+Id Id::fromString(QStringView name)
 {
     if (name.isEmpty())
         return Id();
@@ -202,7 +202,7 @@ Id Id::fromString(const QStringView name)
   \sa toString(), fromSetting()
 */
 
-Id Id::fromName(const QByteArrayView name)
+Id Id::fromName(QByteArrayView name)
 {
     return Id(theId(name.data(), name.size()));
 }
@@ -273,7 +273,7 @@ Id Id::withSuffix(int suffix) const
 /*!
   \overload
 */
-Id Id::withSuffix(const char suffix) const
+Id Id::withSuffix(char suffix) const
 {
     const QByteArray ba = name() + suffix;
     return Id(theId(ba.data(), ba.size()));
@@ -293,7 +293,7 @@ Id Id::withSuffix(const char *suffix) const
   \overload
 */
 
-Id Id::withSuffix(const QStringView suffix) const
+Id Id::withSuffix(QStringView suffix) const
 {
     const QByteArray ba = name() + suffix.toUtf8();
     return Id(theId(ba.data(), ba.size()));
diff --git a/src/libs/utils/id.h b/src/libs/utils/id.h
index 0acc753bdb2..b23c143ccdb 100644
--- a/src/libs/utils/id.h
+++ b/src/libs/utils/id.h
@@ -34,9 +34,9 @@ public:
 #if QT_POINTER_SIZE != 4
     Id withSuffix(int suffix) const;
 #endif
-    Id withSuffix(const char suffix) const;
+    Id withSuffix(char suffix) const;
     Id withSuffix(const char *suffix) const;
-    Id withSuffix(const QStringView suffix) const;
+    Id withSuffix(QStringView suffix) const;
     Id withPrefix(const char *prefix) const;
 
     QByteArrayView name() const;
@@ -54,8 +54,8 @@ public:
     bool operator>(Id id) const { return m_id > id.m_id; }
     bool alphabeticallyBefore(Id other) const;
 
-    static Id fromString(const QStringView str); // FIXME: avoid.
-    static Id fromName(const QByteArrayView ba); // FIXME: avoid.
+    static Id fromString(QStringView str); // FIXME: avoid.
+    static Id fromName(QByteArrayView ba); // FIXME: avoid.
     static Id fromSetting(const QVariant &variant); // Good to use.
 
     static QSet<Id> fromStringList(const QStringList &list);