feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: fix memory leak

Browse Source 
When removing actions from a widget the action is not magically deleted,
so manually delete the language client toolbar action of the editor
after the last client was shutdown.

Change-Id: I6a5a079d4a44724f92d291040925df73f7eb747b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2019-10-28 13:35:41 +01:00
parent 7cec3cfc94
commit 63d03afb95
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/languageclient/languageclientutils.cpp
View File

@@ -213,6 +213,7 @@ void updateEditorToolBar(Core::IEditor *editor)
} else { } else {
widget->toolBar()->removeAction(action); widget->toolBar()->removeAction(action);
actions.remove(widget); actions.remove(widget);
delete action;
} }
} else if (client) { } else if (client) {
const QIcon icon = Utils::Icon({{":/languageclient/images/languageclient.png", const QIcon icon = Utils::Icon({{":/languageclient/images/languageclient.png",