feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Do not use native path separators for source directory

Browse Source 
In target debugging or core dump, the source is typically linux,
so converting the separators doesn't make much sense.

Paths are converted internally by CdbEngine, so no change is needed there.

This is required for regular expressions support.

Change-Id: I19488798856b731ef77a14383d12b110eae5d369
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Orgad Shaneh
2014-09-13 23:30:34 +03:00
committed by Orgad Shaneh
parent dbab3dc2e9
commit 63da3cb9e0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/debugger/debuggersourcepathmappingwidget.cpp
View File

@@ -86,7 +86,7 @@ public:
bool isNewPlaceHolderAt(int row) { return isNewPlaceHolder(rawMappingAt(row)); } bool isNewPlaceHolderAt(int row) { return isNewPlaceHolder(rawMappingAt(row)); }
void addMapping(const QString &source, const QString &target) void addMapping(const QString &source, const QString &target)
{ addRawMapping(QDir::toNativeSeparators(source), QDir::toNativeSeparators(target)); } { addRawMapping(source, QDir::toNativeSeparators(target)); }
void addNewMappingPlaceHolder() void addNewMappingPlaceHolder()
{ addRawMapping(m_newSourcePlaceHolder, m_newTargetPlaceHolder); } { addRawMapping(m_newSourcePlaceHolder, m_newTargetPlaceHolder); }
@@ -176,7 +176,7 @@ void SourcePathMappingModel::setSource(int row, const QString &s)
{ {
QStandardItem *sourceItem = item(row, SourceColumn); QStandardItem *sourceItem = item(row, SourceColumn);
QTC_ASSERT(sourceItem, return); QTC_ASSERT(sourceItem, return);
sourceItem->setText(s.isEmpty() ? m_newSourcePlaceHolder : QDir::toNativeSeparators(s)); sourceItem->setText(s.isEmpty() ? m_newSourcePlaceHolder : s);
} }
void SourcePathMappingModel::setTarget(int row, const QString &t) void SourcePathMappingModel::setTarget(int row, const QString &t)
@@ -285,7 +285,7 @@ QString DebuggerSourcePathMappingWidget::editTargetField() const
void DebuggerSourcePathMappingWidget::setEditFieldMapping(const Mapping &m) void DebuggerSourcePathMappingWidget::setEditFieldMapping(const Mapping &m)
{ {
m_sourceLineEdit->setText(QDir::toNativeSeparators(m.first)); m_sourceLineEdit->setText(m.first);
m_targetChooser->setPath(m.second); m_targetChooser->setPath(m.second);
} }