From 63eca96f99396b45ea8cc7be13728af2d3d6cbcb Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 24 Apr 2018 16:08:10 +0200 Subject: [PATCH] ProjectExplorer: Fix saving of modifiable ExecutableAspects The settings key decides on saving, the underlying BaseStringAspect needs to know it. This only affected RemoteLinuxCustomRunConfig so far. Change-Id: Ic4af9fa752b0b1ae107779d88978495e511cf98c Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/runconfigurationaspects.cpp | 6 ++++++ src/plugins/projectexplorer/runconfigurationaspects.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/plugins/projectexplorer/runconfigurationaspects.cpp b/src/plugins/projectexplorer/runconfigurationaspects.cpp index 76e492e350f..893590e9370 100644 --- a/src/plugins/projectexplorer/runconfigurationaspects.cpp +++ b/src/plugins/projectexplorer/runconfigurationaspects.cpp @@ -554,6 +554,12 @@ void ExecutableAspect::setExecutable(const FileName &executable) m_executable.setValue(executable.toString()); } +void ExecutableAspect::setSettingsKey(const QString &key) +{ + IRunConfigurationAspect::setSettingsKey(key); + m_executable.setSettingsKey(key); +} + void ExecutableAspect::fromMap(const QVariantMap &map) { m_executable.fromMap(map); diff --git a/src/plugins/projectexplorer/runconfigurationaspects.h b/src/plugins/projectexplorer/runconfigurationaspects.h index d8c84da2651..2ba4cf916ef 100644 --- a/src/plugins/projectexplorer/runconfigurationaspects.h +++ b/src/plugins/projectexplorer/runconfigurationaspects.h @@ -230,6 +230,7 @@ public: Utils::FileName executable() const; void setExecutable(const Utils::FileName &executable); + void setSettingsKey(const QString &key); void makeOverridable(const QString &overridingKey, const QString &useOverridableKey); void addToConfigurationLayout(QFormLayout *layout); void setLabelText(const QString &labelText);