feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Pass const values by references

Browse Source 
Change-Id: I9749c0c76b810f3d5fee1aa8c5750dac5930cd3c
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-05 17:12:10 +03:00
committed by Orgad Shaneh
parent b3ff928b0a
commit 642706dc44
5 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/git/branchmodel.cpp
View File

@@ -141,7 +141,7 @@ public:
return fn; return fn;
} }
void insert(const QStringList path, BranchNode *n) void insert(const QStringList &path, BranchNode *n)
{ {
BranchNode *current = this; BranchNode *current = this;
for (int i = 0; i < path.count(); ++i) { for (int i = 0; i < path.count(); ++i) {

2
src/plugins/git/gitclient.cpp
View File

@@ -1096,7 +1096,7 @@ VcsBase::VcsBaseEditorWidget *GitClient::findExistingVCSEditor(const char *regis
return rc; return rc;
} }
DiffEditor::DiffEditorDocument *GitClient::createDiffEditor(const QString documentId, DiffEditor::DiffEditorDocument *GitClient::createDiffEditor(const QString &documentId,
const QString &source, const QString &source,
const QString &title) const const QString &title) const
{ {

2
src/plugins/git/gitclient.h
View File

@@ -356,7 +356,7 @@ private:
const char *registerDynamicProperty, const char *registerDynamicProperty,
const QString &dynamicPropertyValue, const QString &dynamicPropertyValue,
VcsBase::VcsBaseEditorParameterWidget *configWidget) const; VcsBase::VcsBaseEditorParameterWidget *configWidget) const;
DiffEditor::DiffEditorDocument *createDiffEditor(const QString documentId, DiffEditor::DiffEditorDocument *createDiffEditor(const QString &documentId,
const QString &source, const QString &source,
const QString &title) const; const QString &title) const;

3
src/plugins/perforce/perforceplugin.cpp
View File

@@ -1169,7 +1169,8 @@ PerforceResponse PerforcePlugin::runP4Cmd(const QString &workingDir,
return response; return response;
} }
Core::IEditor *PerforcePlugin::showOutputInEditor(const QString &title, const QString output, Core::IEditor *PerforcePlugin::showOutputInEditor(const QString &title,
const QString &output,
int editorType, int editorType,
const QString &source, const QString &source,
QTextCodec *codec) QTextCodec *codec)

2
src/plugins/perforce/perforceplugin.h
View File

@@ -146,7 +146,7 @@ protected:
private: private:
typedef QHash<QString, bool> ManagedDirectoryCache; typedef QHash<QString, bool> ManagedDirectoryCache;
Core::IEditor *showOutputInEditor(const QString& title, const QString output, Core::IEditor *showOutputInEditor(const QString &title, const QString &output,
int editorType, const QString &source, int editorType, const QString &source,
QTextCodec *codec = 0); QTextCodec *codec = 0);