feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Try to find help items for method overrides

Browse Source 
... in the base class.
This is purely a heuristic, but should work well for Qt-based user
projects.

Fixes: QTCREATORBUG-9845
Change-Id: Icca336b3568c2c5f07a9eaf6a183bf6c7c4275bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2022-09-12 15:19:17 +02:00
parent bbf791b1bd
commit 644c438c3a
2 changed files with 50 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -985,6 +985,9 @@ void ClangdClient::gatherHelpItemForTooltip(const HoverRequest::Response &hoverR
type = type.left(angleBracketIndex);
};
if (gatherMemberFunctionOverrideHelpItemForTooltip(id, path))
return;
const bool isMemberFunction = node.role() == "expression" && node.kind() == "Member"
&& (node.arcanaContains("member function") || type.contains('('));
const bool isFunction = node.role() == "expression" && node.kind() == "DeclRef"
@@ -1070,6 +1073,50 @@ void ClangdClient::gatherHelpItemForTooltip(const HoverRequest::Response &hoverR
d->getAndHandleAst(doc, astHandler, AstCallbackMode::SyncIfPossible);
}
bool ClangdClient::gatherMemberFunctionOverrideHelpItemForTooltip(
const LanguageServerProtocol::MessageId &token,
const QList<ClangdAstNode> &path)
{
// Heuristic: If we encounter a member function re-declaration, continue under the
// assumption that the base class holds the documentation.
if (path.length() < 3 || path.last().kind() != "FunctionProto")
return false;
const ClangdAstNode &methodNode = path.at(path.length() - 2);
if (methodNode.kind() != "CXXMethod" || !methodNode.detail())
return false;
bool hasOverride = false;
for (const ClangdAstNode &methodNodeChild
: methodNode.children().value_or(QList<ClangdAstNode>())) {
if (methodNodeChild.kind() == "Override") {
hasOverride = true;
break;
}
}
if (!hasOverride)
return false;
const ClangdAstNode &classNode = path.at(path.length() - 3);
if (classNode.kind() != "CXXRecord")
return false;
const ClangdAstNode baseNode = classNode.children()->first();
if (baseNode.role() != "base")
return false;
const auto baseNodeChildren = baseNode.children();
if (!baseNodeChildren || baseNodeChildren->isEmpty())
return false;
const ClangdAstNode baseTypeNode = baseNodeChildren->first();
if (baseTypeNode.role() != "type")
return false;
const auto baseTypeNodeChildren = baseTypeNode.children();
if (!baseTypeNodeChildren || baseTypeNodeChildren->isEmpty())
return false;
const ClangdAstNode baseClassNode = baseTypeNodeChildren->first();
if (!baseClassNode.detail())
return false;
d->setHelpItemForTooltip(token, *baseClassNode.detail() + "::" + *methodNode.detail(),
HelpItem::Function, "()");
return true;
}
void ClangdClient::setVirtualRanges(const Utils::FilePath &filePath, const QList<Range> &ranges,
int revision)
{