feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Make ClangPathWatcherNotifier non copy-able

Browse Source 
There is already a destructor because the vtable should not be
injected in every translation unit. Because of the rule of five
we have to provide or omit the copy and move functions. So
we delete them because we don't need them and any way
it would be not smart to have to notifier.

Change-Id: I35c00954eaa4e1bb299581a5e4ba5369d5cbf1cd
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Marco Bubke
2017-12-27 13:15:53 +01:00
parent 6f8f8d0cbf
commit 6454e336e5
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/clangsupport/clangpathwatchernotifier.cpp
View File

@@ -27,9 +27,6 @@
namespace ClangBackEnd { namespace ClangBackEnd {
ClangPathWatcherNotifier::~ClangPathWatcherNotifier() ClangPathWatcherNotifier::~ClangPathWatcherNotifier() = default;
{
}
} // namespace ClangBackEnd } // namespace ClangBackEnd

3
src/libs/clangsupport/clangpathwatchernotifier.h
View File

@@ -36,7 +36,10 @@ namespace ClangBackEnd {
class CLANGSUPPORT_EXPORT ClangPathWatcherNotifier class CLANGSUPPORT_EXPORT ClangPathWatcherNotifier
{ {
public: public:
ClangPathWatcherNotifier() = default;
virtual ~ClangPathWatcherNotifier(); virtual ~ClangPathWatcherNotifier();
ClangPathWatcherNotifier(const ClangPathWatcherNotifier &) = delete;
void operator=(const ClangPathWatcherNotifier &) = delete;
virtual void pathsWithIdsChanged(const Utils::SmallStringVector &ids) = 0; virtual void pathsWithIdsChanged(const Utils::SmallStringVector &ids) = 0;
virtual void pathsChanged(const FilePathIds &filePathIds) = 0; virtual void pathsChanged(const FilePathIds &filePathIds) = 0;