feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCSbase: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: I1088047513e7660907182e80303607d8c48919f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Artem Sokolovskii
2022-05-19 16:04:26 +02:00
parent 2c24dc03ac
commit 646254f460
8 changed files with 28 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/vcsbase/submitfieldwidget.cpp
View File

@@ -210,7 +210,7 @@ void SubmitFieldWidget::setHasBrowseButton(bool on)
if (d->hasBrowseButton == on)
return;
d->hasBrowseButton = on;
foreach (const FieldEntry &fe, d->fieldEntries)
for (const FieldEntry &fe : qAsConst(d->fieldEntries))
fe.browseButton->setVisible(on);
}
@@ -234,7 +234,7 @@ void SubmitFieldWidget::setCompleter(QCompleter *c)
if (c == d->completer)
return;
d->completer = c;
foreach (const FieldEntry &fe, d->fieldEntries)
for (const FieldEntry &fe : qAsConst(d->fieldEntries))
fe.lineEdit->setCompleter(c);
}
@@ -254,7 +254,7 @@ QString SubmitFieldWidget::fieldValues() const
const QChar newLine = QLatin1Char('\n');
// Format as "RevBy: value\nSigned-Off: value\n"
QString rc;
foreach (const FieldEntry &fe, d->fieldEntries) {
for (const FieldEntry &fe : qAsConst(d->fieldEntries)) {
const QString value = fe.lineEdit->text().trimmed();
if (!value.isEmpty()) {
rc += fe.combo->currentText();