feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Remove DebuggerCommand .arg chaining.

Browse Source 
Less stylish options for more uniform user code.

Change-Id: Ie9a6558101383a844efa25ba3ab59b4b824ad89f
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-02-05 14:39:59 +01:00
parent 0da9178c3e
commit 648a8e82f0
3 changed files with 55 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/plugins/debugger/debuggerprotocol.cpp
View File

@@ -739,14 +739,13 @@ QString decodeData(const QByteArray &ba, int encoding)
//
//////////////////////////////////////////////////////////////////////////////////
const DebuggerCommand &DebuggerCommand::argHelper(const char *name, const QByteArray &data) const
void DebuggerCommand::argHelper(const char *name, const QByteArray &data)
{
args.append('"');
args.append(name);
args.append("\":");
args.append(data);
args.append(",");
return *this;
}
QByteArray DebuggerCommand::toData(const QList<QByteArray> &value)
@@ -773,50 +772,48 @@ QByteArray DebuggerCommand::toData(const QHash<QByteArray, QByteArray> &value)
return '{' + res + '}';
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, int value) const
void DebuggerCommand::arg(const char *name, int value)
{
return argHelper(name, QByteArray::number(value));
argHelper(name, QByteArray::number(value));
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, qlonglong value) const
void DebuggerCommand::arg(const char *name, qlonglong value)
{
return argHelper(name, QByteArray::number(value));
argHelper(name, QByteArray::number(value));
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, qulonglong value) const
void DebuggerCommand::arg(const char *name, qulonglong value)
{
return argHelper(name, QByteArray::number(value));
argHelper(name, QByteArray::number(value));
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, const QString &value) const
void DebuggerCommand::arg(const char *name, const QString &value)
{
return arg(name, value.toUtf8().data());
arg(name, value.toUtf8().data());
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, const QByteArray &value) const
void DebuggerCommand::arg(const char *name, const QByteArray &value)
{
return arg(name, value.data());
arg(name, value.data());
}
const DebuggerCommand &DebuggerCommand::arg(const char *name, const char *value) const
void DebuggerCommand::arg(const char *name, const char *value)
{
args.append('"');
args.append(name);
args.append("\":\"");
args.append(value);
args.append("\",");
return *this;
}
const DebuggerCommand &DebuggerCommand::arg(const char *value) const
void DebuggerCommand::arg(const char *value)
{
args.append("\"");
args.append(value);
args.append("\",");
return *this;
}
const DebuggerCommand &DebuggerCommand::beginList(const char *name) const
void DebuggerCommand::beginList(const char *name)
{
if (name) {
args += '"';
@@ -824,17 +821,16 @@ const DebuggerCommand &DebuggerCommand::beginList(const char *name) const
args += "\":";
}
args += '[';
return *this;
}
void DebuggerCommand::endList() const
void DebuggerCommand::endList()
{
if (args.endsWith(','))
args.chop(1);
args += "],";
}
const DebuggerCommand &DebuggerCommand::beginGroup(const char *name) const
void DebuggerCommand::beginGroup(const char *name)
{
if (name) {
args += '"';
@@ -842,10 +838,9 @@ const DebuggerCommand &DebuggerCommand::beginGroup(const char *name) const
args += "\":";
}
args += '{';
return *this;
}
void DebuggerCommand::endGroup() const
void DebuggerCommand::endGroup()
{
if (args.endsWith(','))
args.chop(1);