Set history completer only once

Avoid setting it many times for one
path chooser, since it raises soft assert
inside FancyLineEdit.

Change-Id: Ie70224b9be577fc38d32f036a67a9b9a1bc3ac56
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/qmakeprojectmanager/addlibrarywizard.cpp

@@ -189,7 +189,10 @@ DetailsPage::DetailsPage(AddLibraryWizard *parent)
 {
     m_libraryDetailsWidget = new Ui::LibraryDetailsWidget();
     m_libraryDetailsWidget->setupUi(this);
+
     Utils::PathChooser * const libPathChooser = m_libraryDetailsWidget->libraryPathChooser;
+    libPathChooser->setHistoryCompleter("Qmake.LibDir.History");
+
     const auto pathValidator = [libPathChooser](Utils::FancyLineEdit *edit, QString *errorMessage) {
         return libPathChooser->defaultValidationFunction()(edit, errorMessage)
                 && validateLibraryPath(libPathChooser->fileName().toString(), libPathChooser,

src/plugins/qmakeprojectmanager/librarydetailscontroller.cpp

@@ -612,9 +612,6 @@ NonInternalLibraryDetailsController::NonInternalLibraryDetailsController(
     setLibraryComboBoxVisible(false);
     setLibraryPathChooserVisible(true);
 
-    libraryDetailsWidget()->libraryPathChooser
-            ->setHistoryCompleter(QLatin1String("Qmake.LibDir.History"));
-
     if (creatorPlatform() == CreatorWindows) {
         libraryDetailsWidget()->libraryPathChooser->setPromptDialogFilter(
                 QLatin1String("Library file (*.lib lib*.a)"));