feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Beautifier: change QTC_CHECK to QTC_ASSERT.

Browse Source 
Return when the check fails, so there won't be a nullptr deref 2 lines
down.

Change-Id: I4dd1ba13798a57700c486e4b1f24b45afb2837ad
Reviewed-by: Lorenz Haas <lykurg@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
This commit is contained in:
Erik Verbruggen
2014-09-11 10:43:54 +02:00
committed by Erik Verbruggen
parent 5efe24b6b3
commit 64a0a72a54
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/beautifier/configurationeditor.cpp
View File

@@ -118,7 +118,7 @@ ConfigurationEditor::ConfigurationEditor(QWidget *parent)
void ConfigurationEditor::setSettings(AbstractSettings *settings) void ConfigurationEditor::setSettings(AbstractSettings *settings)
{ {
QTC_CHECK(settings); QTC_ASSERT(settings, return);
m_settings = settings; m_settings = settings;
QStringList keywords = m_settings->options(); QStringList keywords = m_settings->options();