From 64c7f28c6acc00a52c82b1eda89f5e3581ec9431 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Tue, 5 Jul 2016 10:42:13 +0200 Subject: [PATCH] ClangStaticAnalyzer: Print shell quoted command line ...by using QtcProcess::quoteArg(). Change-Id: Ic7c160d0332456e94e0d5fa1ca51320b8c1dd394 Reviewed-by: Christian Kandeler --- .../clangstaticanalyzer/clangstaticanalyzerrunner.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzerrunner.cpp b/src/plugins/clangstaticanalyzer/clangstaticanalyzerrunner.cpp index 3b5e24612cc..291e19ece96 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzerrunner.cpp +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzerrunner.cpp @@ -27,6 +27,7 @@ #include "clangstaticanalyzerconstants.h" +#include #include #include @@ -111,7 +112,7 @@ bool ClangStaticAnalyzerRunner::run(const QString &filePath, const QStringList & QTC_ASSERT(!m_logFile.isEmpty(), return false); const QStringList arguments = constructCommandLineArguments(filePath, m_logFile, compilerOptions); - m_commandLine = (QStringList(m_clangExecutable) + arguments).join(QLatin1String("\" \"")); + m_commandLine = Utils::QtcProcess::joinArgs(QStringList(m_clangExecutable) + arguments); qCDebug(LOG) << "Starting" << m_commandLine; m_process.start(m_clangExecutable, arguments); @@ -171,7 +172,7 @@ QString ClangStaticAnalyzerRunner::createLogFile(const QString &filePath) const QString ClangStaticAnalyzerRunner::processCommandlineAndOutput() const { - return tr("Command line: \"%1\"\n" + return tr("Command line: %1\n" "Process Error: %2\n" "Output:\n%3") .arg(m_commandLine,