diff --git a/src/plugins/help/helpwidget.cpp b/src/plugins/help/helpwidget.cpp index bb9cce069dd..65177c29cbe 100644 --- a/src/plugins/help/helpwidget.cpp +++ b/src/plugins/help/helpwidget.cpp @@ -736,7 +736,9 @@ HelpViewer *HelpWidget::insertViewer(int index, const QUrl &url) emit m_model.dataChanged(m_model.index(i, 0), m_model.index(i, 0)); }); - connect(viewer, &HelpViewer::loadFinished, this, &HelpWidget::highlightSearchTerms); + connect(viewer, &HelpViewer::loadFinished, this, [this, viewer] { + highlightSearchTerms(viewer); + }); connect(viewer, &HelpViewer::newPageRequested, this, &HelpWidget::openNewPage); connect(viewer, &HelpViewer::externalPageRequested, this, [this](const QUrl &url) { emit requestShowHelpUrl(url, Core::HelpManager::ExternalHelpAlways); @@ -1005,13 +1007,11 @@ void HelpWidget::print(HelpViewer *viewer) viewer->print(m_printer); } -void HelpWidget::highlightSearchTerms() +void HelpWidget::highlightSearchTerms(HelpViewer *viewer) { if (m_searchTerms.isEmpty()) return; - auto viewer = qobject_cast(sender()); - QTC_ASSERT(viewer, return); - foreach (const QString& term, m_searchTerms) + for (const QString &term : qAsConst(m_searchTerms)) viewer->findText(term, {}, false, true); m_searchTerms.clear(); } diff --git a/src/plugins/help/helpwidget.h b/src/plugins/help/helpwidget.h index 8ac5b646b26..938fb7cab93 100644 --- a/src/plugins/help/helpwidget.h +++ b/src/plugins/help/helpwidget.h @@ -138,7 +138,7 @@ private: void scaleDown(); void resetScale(); void print(HelpViewer *viewer); - void highlightSearchTerms(); + void highlightSearchTerms(HelpViewer *viewer); void addSideBar(); QString sideBarSettingsKey() const;