From 651b9ff65eb0a6f2faf5ad1e3a64dd9f04841d4c Mon Sep 17 00:00:00 2001 From: Christiaan Janssen Date: Thu, 31 May 2012 12:00:49 +0200 Subject: [PATCH] QmlProfiler: added tooltip for non-optimized bindings Change-Id: I4500b168c016e7d5525124996be4886e481065d9 Reviewed-by: Aurindam Jana --- src/plugins/qmlprofiler/qmlprofilereventview.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/plugins/qmlprofiler/qmlprofilereventview.cpp b/src/plugins/qmlprofiler/qmlprofilereventview.cpp index 0e183a9461f..e50363da1a5 100644 --- a/src/plugins/qmlprofiler/qmlprofilereventview.cpp +++ b/src/plugins/qmlprofiler/qmlprofilereventview.cpp @@ -611,9 +611,15 @@ void QmlProfilerEventsMainView::QmlProfilerEventsMainViewPrivate::buildModelFrom if (m_fieldShown[Type]) { QString typeString = QmlProfilerEventsMainView::nameForType(binding->eventType); QString toolTipText; - if (binding->eventType == Binding && binding->bindingType == (int)OptimizedBinding) { - typeString = typeString + tr(" (Opt)"); - toolTipText = tr("Binding is evaluated by the optimized engine."); + if (binding->eventType == Binding) { + if (binding->bindingType == (int)OptimizedBinding) { + typeString = typeString + tr(" (Opt)"); + toolTipText = tr("Binding is evaluated by the optimized engine."); + } else if (binding->bindingType == (int)V8Binding) { + toolTipText = tr("Binding not optimized (eg. has side effects or assignments,\n" + "references to elements in other files, loops, etc.)"); + + } } newRow << new EventsViewItem(typeString); newRow.last()->setData(QVariant(typeString));