feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ToolChain: Remove unnecessary parameter

Browse Source 
Change-Id: I7918a0eb89b2d3a3edcbb6bec4021db89c546a72
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
This commit is contained in:
Tobias Hunger
2012-02-21 12:00:45 +01:00
parent da2aa0df72
commit 6572cfa5bb
6 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/gcctoolchain.cpp
View File

@@ -795,7 +795,7 @@ void Internal::GccToolChainConfigWidget::handleAbiChange()
m_autoDebuggerCommand = ToolChainManager::instance()->defaultDebugger(abi); m_autoDebuggerCommand = ToolChainManager::instance()->defaultDebugger(abi);
setDebuggerCommand(m_autoDebuggerCommand); setDebuggerCommand(m_autoDebuggerCommand);
} }
emit dirty(toolChain()); emit dirty();
} }
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------

2
src/plugins/projectexplorer/toolchainconfigwidget.cpp
View File

@@ -149,7 +149,7 @@ void ToolChainConfigWidget::emitDirty()
d->m_mkspecEdited = (mkspecListFromString(d->m_mkspecEdit->text()) != d->m_suggestedMkspec); d->m_mkspecEdited = (mkspecListFromString(d->m_mkspecEdit->text()) != d->m_suggestedMkspec);
if (d->m_mkspecResetButton) if (d->m_mkspecResetButton)
d->m_mkspecResetButton->setEnabled(d->m_mkspecEdited); d->m_mkspecResetButton->setEnabled(d->m_mkspecEdited);
emit dirty(toolChain()); emit dirty();
} }
void ToolChainConfigWidget::resetMkspecList() void ToolChainConfigWidget::resetMkspecList()

2
src/plugins/projectexplorer/toolchainconfigwidget.h
View File

@@ -71,7 +71,7 @@ public:
virtual void makeReadOnly(); virtual void makeReadOnly();
signals: signals:
void dirty(ProjectExplorer::ToolChain *); void dirty();
protected slots: protected slots:
void emitDirty(); void emitDirty();

9
src/plugins/projectexplorer/toolchainoptionspage.cpp
View File

@@ -285,10 +285,11 @@ bool ToolChainModel::isDirty(ToolChain *tc) const
return false; return false;
} }
void ToolChainModel::setDirty(ToolChain *tc) void ToolChainModel::setDirty()
{ {
ToolChainConfigWidget *w = qobject_cast<ToolChainConfigWidget *>(sender());
foreach (ToolChainNode *n, m_manualRoot->childNodes) { foreach (ToolChainNode *n, m_manualRoot->childNodes) {
if (n->toolChain == tc) { if (n->widget == w) {
n->changed = true; n->changed = true;
emit dataChanged(index(n, 0), index(n, columnCount(QModelIndex()))); emit dataChanged(index(n, 0), index(n, columnCount(QModelIndex())));
} }
@@ -404,8 +405,8 @@ ToolChainNode *ToolChainModel::createNode(ToolChainNode *parent, ToolChain *tc,
ToolChainNode *node = new ToolChainNode(parent, tc, changed); ToolChainNode *node = new ToolChainNode(parent, tc, changed);
if (node->widget) { if (node->widget) {
m_configWidgetParent->layout()->addWidget(node->widget); m_configWidgetParent->layout()->addWidget(node->widget);
connect(node->widget, SIGNAL(dirty(ProjectExplorer::ToolChain*)), connect(node->widget, SIGNAL(dirty()),
this, SLOT(setDirty(ProjectExplorer::ToolChain*))); this, SLOT(setDirty()));
} }
return node; return node;
} }

2
src/plugins/projectexplorer/toolchainoptionspage.h
View File

@@ -96,7 +96,7 @@ signals:
private slots: private slots:
void addToolChain(ProjectExplorer::ToolChain *); void addToolChain(ProjectExplorer::ToolChain *);
void removeToolChain(ProjectExplorer::ToolChain *); void removeToolChain(ProjectExplorer::ToolChain *);
void setDirty(ProjectExplorer::ToolChain *); void setDirty();
private: private:
QModelIndex index(ToolChainNode *, int column = 0) const; QModelIndex index(ToolChainNode *, int column = 0) const;

2
src/plugins/qt4projectmanager/qt-s60/winscwtoolchain.cpp
View File

@@ -369,7 +369,7 @@ void WinscwToolChainConfigWidget::handleCompilerPathUpdate()
void WinscwToolChainConfigWidget::makeDirty() void WinscwToolChainConfigWidget::makeDirty()
{ {
emit dirty(toolChain()); emit dirty();
} }
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------