TextEditor: Clean up BaseHoverHandler

Change-Id: Ie2f0c8c0a46377ae18ff4e31c7e43b1242cb7372
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Nikolai Kosjar
2017-06-28 14:33:54 +02:00
parent 3afbd1e5cc
commit 658e468d80
2 changed files with 12 additions and 25 deletions

View File

@@ -26,19 +26,10 @@
#include "basehoverhandler.h" #include "basehoverhandler.h"
#include "texteditor.h" #include "texteditor.h"
#include <coreplugin/icore.h>
#include <utils/tooltip/tooltip.h> #include <utils/tooltip/tooltip.h>
#include <QPoint>
using namespace Core;
namespace TextEditor { namespace TextEditor {
BaseHoverHandler::BaseHoverHandler() : m_diagnosticTooltip(false), m_priority(-1)
{
}
BaseHoverHandler::~BaseHoverHandler() BaseHoverHandler::~BaseHoverHandler()
{} {}

View File

@@ -32,26 +32,30 @@ QT_BEGIN_NAMESPACE
class QPoint; class QPoint;
QT_END_NAMESPACE QT_END_NAMESPACE
namespace Core { class IEditor; }
namespace TextEditor { namespace TextEditor {
class BaseTextEditor;
class TextEditorWidget; class TextEditorWidget;
class TEXTEDITOR_EXPORT BaseHoverHandler class TEXTEDITOR_EXPORT BaseHoverHandler
{ {
public: public:
BaseHoverHandler();
virtual ~BaseHoverHandler(); virtual ~BaseHoverHandler();
QString contextHelpId(TextEditorWidget *widget, int pos); QString contextHelpId(TextEditorWidget *widget, int pos);
int checkToolTip(TextEditorWidget *widget, int pos); int checkToolTip(TextEditorWidget *widget, int pos);
void showToolTip(TextEditorWidget *widget, const QPoint &point, int pos); void showToolTip(TextEditorWidget *widget, const QPoint &point, int pos);
protected:
enum {
Priority_None = 0,
Priority_Tooltip = 5,
Priority_Help = 10,
Priority_Diagnostic = 20
};
void setPriority(int priority);
int priority() const; int priority() const;
protected:
void setToolTip(const QString &tooltip); void setToolTip(const QString &tooltip);
void appendToolTip(const QString &extension); void appendToolTip(const QString &extension);
const QString &toolTip() const; const QString &toolTip() const;
@@ -62,26 +66,18 @@ protected:
void setLastHelpItemIdentified(const HelpItem &help); void setLastHelpItemIdentified(const HelpItem &help);
const HelpItem &lastHelpItemIdentified() const; const HelpItem &lastHelpItemIdentified() const;
virtual void identifyMatch(TextEditorWidget *editorWidget, int pos);
virtual void decorateToolTip(); virtual void decorateToolTip();
virtual void operateTooltip(TextEditorWidget *editorWidget, const QPoint &point); virtual void operateTooltip(TextEditorWidget *editorWidget, const QPoint &point);
enum {
Priority_None = 0,
Priority_Tooltip = 5,
Priority_Help = 10,
Priority_Diagnostic = 20
};
void setPriority(int priority);
private: private:
void clear(); void clear();
void process(TextEditorWidget *widget, int pos); void process(TextEditorWidget *widget, int pos);
virtual void identifyMatch(TextEditorWidget *editorWidget, int pos); bool m_diagnosticTooltip = false;
bool m_diagnosticTooltip;
QString m_toolTip; QString m_toolTip;
HelpItem m_lastHelpItemIdentified; HelpItem m_lastHelpItemIdentified;
int m_priority; int m_priority = -1;
}; };
} // namespace TextEditor } // namespace TextEditor