feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Fix CppCheck warnings in BranchModel

Browse Source 
Change-Id: I8c9fa0bff6e33675ad2a72176c4640f4dca3d51b
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2019-05-05 22:47:52 +03:00
committed by Orgad Shaneh
parent 1de548d1cb
commit 6595a161fc
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/git/branchmodel.cpp
View File

@@ -199,12 +199,15 @@ public:
class BranchModel::Private
{
public:
Private(GitClient *client) :
explicit Private(GitClient *client) :
client(client),
rootNode(new BranchNode)
{
}
Private(const Private &) = delete;
Private &operator=(const Private &) = delete;
~Private()
{
delete rootNode;
@@ -648,8 +651,6 @@ QModelIndex BranchModel::addBranch(const QString &name, bool track, const QModel
startSha = sha(startPoint);
branchDateTime = dateTime(startPoint);
} else {
QString output;
QString errorMessage;
const QStringList arguments({"-n1", "--format=%H %ct"});
if (d->client->synchronousLog(d->workingDirectory, arguments, &output, &errorMessage,
VcsCommand::SuppressCommandLogging)) {