feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Catch exceptions by const reference.

Browse Source 
Change-Id: Ic537fd123478a4f8fe4e54736d444fa64fd62d9c
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Christian Kandeler
2014-11-28 11:15:37 +01:00
parent ee45dc6db5
commit 6595c0a9d1
30 changed files with 99 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/ssh/sshconnection.cpp
View File

@@ -329,13 +329,13 @@ void SshConnectionPrivate::handleIncomingData()
if (m_serverId.isEmpty())
handleServerId();
handlePackets();
} catch (SshServerException &e) {
} catch (const SshServerException &e) {
closeConnection(e.error, SshProtocolError, e.errorStringServer,
tr("SSH Protocol error: %1").arg(e.errorStringUser));
} catch (SshClientException &e) {
} catch (const SshClientException &e) {
closeConnection(SSH_DISCONNECT_BY_APPLICATION, e.error, "",
e.errorString);
} catch (Botan::Exception &e) {
} catch (const Botan::Exception &e) {
closeConnection(SSH_DISCONNECT_BY_APPLICATION, SshInternalError, "",
tr("Botan library exception: %1").arg(QString::fromLatin1(e.what())));
}
@@ -784,7 +784,7 @@ void SshConnectionPrivate::closeConnection(SshErrorCode sshError,
try {
m_channelManager->closeAllChannels(SshChannelManager::CloseAllAndReset);
m_sendFacility.sendDisconnectPacket(sshError, serverErrorString);
} catch (Botan::Exception &) {} // Nothing sensible to be done here.
} catch (const Botan::Exception &) {} // Nothing sensible to be done here.
if (m_error != SshNoError)
emit error(userError);
if (m_state == ConnectionEstablished)