feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Delay expansion request

Browse Source 
Do not directly expand an item directly after it had
been added to the model as its internal mappings need
to get updated.

Fixes: QTCREATORBUG-29302
Change-Id: If70d209074d97e0598bcbce061e176148751705a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2023-06-22 15:22:35 +02:00
parent 150ca56067
commit 65b1088a17
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/autotest/testresultmodel.cpp
View File

@@ -298,9 +298,8 @@ void TestResultModel::addTestResult(const TestResult &testResult, bool autoExpan
if (parentItem) { if (parentItem) {
parentItem->appendChild(newItem); parentItem->appendChild(newItem);
if (autoExpand) { if (autoExpand) {
parentItem->expand(); QMetaObject::invokeMethod(this, [parentItem]{ parentItem->expand(); },
newItem->expand(); Qt::QueuedConnection);
newItem->forAllChildren([](TreeItem *it) { it->expand(); });
} }
updateParent(newItem); updateParent(newItem);
} else { } else {

2
src/plugins/autotest/testresultspane.cpp
View File

@@ -142,7 +142,7 @@ TestResultsPane::TestResultsPane(QObject *parent) :
onCopyItemTriggered(getTestResult(m_treeView->currentIndex())); onCopyItemTriggered(getTestResult(m_treeView->currentIndex()));
}); });
connect(m_model, &TestResultModel::requestExpansion, this, [this](const QModelIndex &idx) { connect(m_model, &TestResultModel::requestExpansion, this, [this](const QModelIndex &idx) {
m_treeView->expand(m_filterModel->mapFromSource(idx)); m_treeView->expandRecursively(m_filterModel->mapFromSource(idx));
}); });
connect(TestRunner::instance(), &TestRunner::testRunStarted, connect(TestRunner::instance(), &TestRunner::testRunStarted,
this, &TestResultsPane::onTestRunStarted); this, &TestResultsPane::onTestRunStarted);