feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AnalyzerBase: Fix opening links with Windows drive letters

Browse Source 
Change-Id: Iba365f9abeff2573296295e50a6100cc480374b4
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Nikolai Kosjar
2014-10-20 17:18:41 +02:00
parent 49c39eb029
commit 65e9da282f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/analyzerbase/detailederrorview.cpp
View File

@@ -203,11 +203,13 @@ void DetailedErrorDelegate::onVerticalScroll()
// Expects "file://some/path[:line[:column]]" - the line/column part is optional // Expects "file://some/path[:line[:column]]" - the line/column part is optional
void DetailedErrorDelegate::openLinkInEditor(const QString &link) void DetailedErrorDelegate::openLinkInEditor(const QString &link)
{ {
const QString pathLineColumn = link.mid(int(sizeof("file://")) - 1); const QString linkWithoutPrefix = link.mid(strlen("file://"));
const QChar separator = QLatin1Char(':'); const QChar separator = QLatin1Char(':');
const QString path = pathLineColumn.section(separator, 0, 0); const int lineColon = linkWithoutPrefix.indexOf(separator, /*after drive letter + colon =*/ 2);
const int line = pathLineColumn.section(separator, 1, 1).toInt(); const QString path = linkWithoutPrefix.left(lineColon);
const int column = pathLineColumn.section(separator, 2, 2).toInt(); const QString lineColumn = linkWithoutPrefix.mid(lineColon + 1);
const int line = lineColumn.section(separator, 0, 0).toInt();
const int column = lineColumn.section(separator, 1, 1).toInt();
Core::EditorManager::openEditorAt(path, qMax(line, 0), qMax(column, 0)); Core::EditorManager::openEditorAt(path, qMax(line, 0), qMax(column, 0));
} }