feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Clean up cppvirtualfunctionassistprovider.cpp

Browse Source 
- Moves the findMatchingClassDeclaration() call from
  FollowSymbolUnderCursor::findLink into VirtualFunctionsAssistProcessor
  since we already have a SymbolFinder there
- Make canLookupVirtualFunctionOverrides a class member because we plan
  to add some methods
- Better parameter names/order for FunctionHelper::overrides()

Change-Id: I0a93ff5445352d47e808adad45485e520f06946e
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This commit is contained in:
Nikolai Kosjar
2013-10-25 15:04:51 +02:00
parent 8f0be66d3d
commit 65f13fe05c
3 changed files with 74 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/cppeditor/cppvirtualfunctionassistprovider.h
View File

@@ -48,9 +48,8 @@ public:
VirtualFunctionAssistProvider();
struct Parameters {
Parameters() : startClass(0), function(0), cursorPosition(-1), openInNextSplit(false) {}
Parameters() : function(0), cursorPosition(-1), openInNextSplit(false) {}
CPlusPlus::Class *startClass;
CPlusPlus::Function *function;
QSharedPointer<CPlusPlus::TypeOfExpression> typeOfExpression; // Keeps instantiated symbols.
CPlusPlus::Snapshot snapshot;
@@ -79,8 +78,8 @@ public:
static bool isPureVirtualFunction(const CPlusPlus::Function *function,
const CPlusPlus::Snapshot &snapshot);
static QList<CPlusPlus::Symbol *> overrides(CPlusPlus::Class *startClass,
CPlusPlus::Function *function,
static QList<CPlusPlus::Symbol *> overrides(CPlusPlus::Function *function,
CPlusPlus::Class *functionsClass,
const CPlusPlus::Snapshot &snapshot);
};