From 65f5fde2e6aa75e0b0543a74b8fc9c4c359874ff Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 25 Mar 2022 18:34:54 +0100 Subject: [PATCH] AndroidAvdManager: Get rid of no-op call to QtcProcess::terminate() Calling QtcProcess::terminate() is a task for implicit ProcessReaper. Delete the process instead. Change-Id: I92fe34a18e15ca95f6bab2b7932faeee8b92621d Reviewed-by: Alessandro Portale --- src/plugins/android/androidavdmanager.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/plugins/android/androidavdmanager.cpp b/src/plugins/android/androidavdmanager.cpp index c82779b6dc8..2602f434c72 100644 --- a/src/plugins/android/androidavdmanager.cpp +++ b/src/plugins/android/androidavdmanager.cpp @@ -162,14 +162,6 @@ static CreateAvdInfo createAvdCommand(const AndroidConfig &config, const CreateA } } - // Kill the running process. - if (proc.state() != QProcess::NotRunning) { - proc.terminate(); - if (!proc.waitForFinished(3000)) - proc.kill(); - } - - QTC_CHECK(proc.state() == QProcess::NotRunning); result.error = errorOutput; return result; }