From 6655f3725919990ccb90c5bebae2476200d56a47 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 1 Aug 2018 13:45:49 +0200 Subject: [PATCH] QmlDesigner: Fix clazy warning Remove superfluous call to default constructors. Change-Id: Id16d7641a28b1d4b58c8bfe26b7076e8122b72c3 Reviewed-by: Alessandro Portale Reviewed-by: Marco Bubke --- .../components/formeditor/formeditorwidget.cpp | 3 +-- .../qmldesigner/components/formeditor/layeritem.cpp | 1 - .../qmldesigner/components/navigator/navigatorwidget.cpp | 7 +++---- .../components/stateseditor/stateseditorwidget.cpp | 7 +++---- .../qmldesigner/designercore/model/qmlobjectnode.cpp | 1 - src/plugins/qmldesigner/designercore/model/qmlstate.cpp | 1 - .../qmldesignerextension/colortool/colortool.cpp | 1 - .../qmldesignerextension/pathtool/pathitem.cpp | 9 ++++----- .../qmldesignerextension/pathtool/pathtool.cpp | 4 +--- .../qmldesignerextension/pathtool/pathtoolview.cpp | 3 +-- .../qmldesignerextension/sourcetool/sourcetool.cpp | 2 -- .../qmldesignerextension/texttool/textedititemwidget.cpp | 1 - .../qmldesignerextension/texttool/texttool.cpp | 1 - 13 files changed, 13 insertions(+), 28 deletions(-) diff --git a/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp b/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp index 4bc952dd8ce..954f8fee661 100644 --- a/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp +++ b/src/plugins/qmldesigner/components/formeditor/formeditorwidget.cpp @@ -55,8 +55,7 @@ namespace QmlDesigner { -FormEditorWidget::FormEditorWidget(FormEditorView *view) - : QWidget(), +FormEditorWidget::FormEditorWidget(FormEditorView *view) : m_formEditorView(view) { setStyleSheet(Theme::replaceCssColors(QString::fromUtf8(Utils::FileReader::fetchQrc(QLatin1String(":/qmldesigner/formeditorstylesheet.css"))))); diff --git a/src/plugins/qmldesigner/components/formeditor/layeritem.cpp b/src/plugins/qmldesigner/components/formeditor/layeritem.cpp index fc56379f312..993e6c382c3 100644 --- a/src/plugins/qmldesigner/components/formeditor/layeritem.cpp +++ b/src/plugins/qmldesigner/components/formeditor/layeritem.cpp @@ -31,7 +31,6 @@ namespace QmlDesigner { LayerItem::LayerItem(FormEditorScene* scene) - : QGraphicsObject() { scene->addItem(this); setZValue(1); diff --git a/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp b/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp index 43f13c2bf3b..17f86509508 100644 --- a/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp +++ b/src/plugins/qmldesigner/components/navigator/navigatorwidget.cpp @@ -45,10 +45,9 @@ namespace QmlDesigner { -NavigatorWidget::NavigatorWidget(NavigatorView *view) : - QFrame(), - m_treeView(new NavigatorTreeView), - m_navigatorView(view) +NavigatorWidget::NavigatorWidget(NavigatorView *view) + : m_treeView(new NavigatorTreeView), + m_navigatorView(view) { m_treeView->setDragEnabled(true); m_treeView->setAcceptDrops(true); diff --git a/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp b/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp index 7b6358f2519..956b0d32a63 100644 --- a/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp +++ b/src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp @@ -85,10 +85,9 @@ void StatesEditorWidget::showAddNewStatesButton(bool showAddNewStatesButton) } StatesEditorWidget::StatesEditorWidget(StatesEditorView *statesEditorView, StatesEditorModel *statesEditorModel) - : QQuickWidget(), - m_statesEditorView(statesEditorView), - m_imageProvider(nullptr), - m_qmlSourceUpdateShortcut(nullptr) + : m_statesEditorView(statesEditorView), + m_imageProvider(nullptr), + m_qmlSourceUpdateShortcut(nullptr) { m_imageProvider = new Internal::StatesEditorImageProvider; m_imageProvider->setNodeInstanceView(statesEditorView->nodeInstanceView()); diff --git a/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp index 6d598350f77..650d1e73059 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlobjectnode.cpp @@ -568,7 +568,6 @@ QmlItemNode QmlObjectNode::itemForInstance(const NodeInstance &instance) const } QmlObjectNode::QmlObjectNode() - : QmlModelNodeFacade() { } diff --git a/src/plugins/qmldesigner/designercore/model/qmlstate.cpp b/src/plugins/qmldesigner/designercore/model/qmlstate.cpp index c937d446d66..adb56076eb1 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlstate.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlstate.cpp @@ -38,7 +38,6 @@ namespace QmlDesigner { QmlModelState::QmlModelState() - : QmlModelNodeFacade() { } diff --git a/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp b/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp index 283cdb901de..32a5742f9f6 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/colortool/colortool.cpp @@ -89,7 +89,6 @@ protected: }; ColorTool::ColorTool() - : QObject(), AbstractCustomTool() { auto colorToolAction = new ColorToolAction; QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(colorToolAction); diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp index 6d858a86de2..0d5b380747d 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathitem.cpp @@ -42,11 +42,10 @@ namespace QmlDesigner { PathItem::PathItem(FormEditorScene* scene) - : QGraphicsObject(), - m_selectionManipulator(this), - m_lastPercent(-1.), - m_formEditorItem(nullptr), - m_dontUpdatePath(false) + : m_selectionManipulator(this), + m_lastPercent(-1.), + m_formEditorItem(nullptr), + m_dontUpdatePath(false) { scene->addItem(this); setFlag(QGraphicsItem::ItemIsMovable, false); diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp index 6873c8e62c9..a01ae050acd 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtool.cpp @@ -140,9 +140,7 @@ protected: }; PathTool::PathTool() - : QObject(), - AbstractCustomTool(), - m_pathToolView(this) + : m_pathToolView(this) { auto textToolAction = new PathToolAction; QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(textToolAction); diff --git a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp index a15abf569e3..ea1e28832ad 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/pathtool/pathtoolview.cpp @@ -37,8 +37,7 @@ namespace QmlDesigner { PathToolView::PathToolView(PathTool *pathTool) - : AbstractView(), - m_pathTool(pathTool) + : m_pathTool(pathTool) { } diff --git a/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp b/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp index 0dad29f3c20..d121e60c73b 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/sourcetool/sourcetool.cpp @@ -115,7 +115,6 @@ protected: SourceTool::SourceTool() - : QObject(), AbstractCustomTool() { auto sourceToolAction = new SourceToolAction; QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(sourceToolAction); @@ -169,7 +168,6 @@ void SourceTool::mouseReleaseEvent(const QList &itemList, AbstractFormEditorTool::mouseReleaseEvent(itemList, event); } - void SourceTool::mouseDoubleClickEvent(const QList &itemList, QGraphicsSceneMouseEvent *event) { AbstractFormEditorTool::mouseDoubleClickEvent(itemList, event); diff --git a/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp b/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp index 750589aa9a8..40efb67e776 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/texttool/textedititemwidget.cpp @@ -34,7 +34,6 @@ namespace QmlDesigner { TextEditItemWidget::TextEditItemWidget(QGraphicsScene* scene) - : QGraphicsProxyWidget() { scene->addItem(this); setFlag(QGraphicsItem::ItemIsMovable, false); diff --git a/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp b/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp index 1d22f2f8766..76dc414c03f 100644 --- a/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp +++ b/src/plugins/qmldesigner/qmldesignerextension/texttool/texttool.cpp @@ -93,7 +93,6 @@ protected: }; TextTool::TextTool() - : QObject() , AbstractCustomTool() { auto textToolAction = new TextToolAction; QmlDesignerPlugin::instance()->designerActionManager().addDesignerAction(textToolAction);