feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BinEditor: Also create IEditors, but don't show them for memory views

Browse Source 
To simplify the different code paths, still on the way to allow
duplication of editors.

Change-Id: I09f8e9faee4b5b6c8179f56341997024daa8681a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2024-07-30 12:55:28 +02:00
parent 255e63bebb
commit 667188c242
1 changed files with 9 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/plugins/bineditor/bineditorplugin.cpp
View File

@@ -2262,29 +2262,18 @@ class BinEditorFactoryService final : public QObject, public FactoryService
Q_INTERFACES(BinEditor::FactoryService)
public:
EditorService *createEditorService(const QString &title0, bool wantsEditor) final
EditorService *createEditorService(const QString &title, bool wantsEditor) final
{
if (!wantsEditor) {
auto document = new BinEditorDocument;
auto widget = new BinEditorWidget(document);
widget->setWindowTitle(title0);
widget->setWindowTitle(title);
auto service = new BinEditorService;
service->m_widget = widget;
service->m_document = document;
return service;
}
QString title = title0;
IEditor *editor = EditorManager::openEditorWithContents(
Core::Constants::K_DEFAULT_BINARY_EDITOR_ID, &title);
if (!editor)
return nullptr;
auto service = new BinEditorService;
service->m_editor = editor;
service->m_widget = qobject_cast<BinEditorWidget *>(editor->widget());
service->m_document = qobject_cast<BinEditorDocument *>(editor->document());
service->m_editor = new BinEditorImpl(widget, document);
if (wantsEditor)
EditorManager::activateEditor(service->m_editor);
return service;
}
};