From 6688623b3707a38923d67da70fa40de0d8a680ce Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Fri, 7 Sep 2018 13:55:48 +0200
Subject: [PATCH] ProjectExplorer: rename RunConfiguration::extraApects() to
 aspects()

It's the standard way nowaday, nothing 'extra' to it anymore.

Also change to ranged for when using it.

Change-Id: Ic39480e736ba09fdcafc38d5e8d16ee4ec750fdd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
---
 src/plugins/projectexplorer/runconfiguration.h            | 2 +-
 src/plugins/projectexplorer/runsettingspropertiespage.cpp | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h
index 0277abdd227..d8b013da916 100644
--- a/src/plugins/projectexplorer/runconfiguration.h
+++ b/src/plugins/projectexplorer/runconfiguration.h
@@ -202,7 +202,7 @@ public:
     bool fromMap(const QVariantMap &map) override;
     QVariantMap toMap() const override;
 
-    QList<IRunConfigurationAspect *> extraAspects() const;
+    const QList<IRunConfigurationAspect *> aspects() const;
     IRunConfigurationAspect *extraAspect(Core::Id id) const;
 
     template <typename T> T *extraAspect() const
diff --git a/src/plugins/projectexplorer/runsettingspropertiespage.cpp b/src/plugins/projectexplorer/runsettingspropertiespage.cpp
index 5262fcc8dc1..a7bf42fc027 100644
--- a/src/plugins/projectexplorer/runsettingspropertiespage.cpp
+++ b/src/plugins/projectexplorer/runsettingspropertiespage.cpp
@@ -528,9 +528,8 @@ QString RunSettingsWidget::uniqueRCName(const QString &name)
 
 void RunSettingsWidget::addRunControlWidgets()
 {
-    foreach (IRunConfigurationAspect *aspect, m_runConfiguration->extraAspects()) {
-        RunConfigWidget *rcw = aspect->createConfigurationWidget();
-        if (rcw)
+    for (IRunConfigurationAspect *aspect : m_runConfiguration->aspects()) {
+        if (RunConfigWidget *rcw = aspect->createConfigurationWidget())
             addSubWidget(rcw);
     }
 }