RemoteLinux: Add more forward declarations

Change-Id: Ie1182248e3b423ce3b85a2baf0c2d7be74de1126
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

src/plugins/boot2qt/qdbmakedefaultappstep.cpp

@@ -31,6 +31,7 @@
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/target.h>
 
+#include <remotelinux/abstractremotelinuxdeployservice.h>
 #include <remotelinux/abstractremotelinuxdeploystep.h>
 
 #include <utils/commandline.h>

src/plugins/boot2qt/qdbstopapplicationstep.cpp

@@ -33,6 +33,7 @@
 #include <projectexplorer/runcontrol.h>
 #include <projectexplorer/target.h>
 
+#include <remotelinux/abstractremotelinuxdeployservice.h>
 #include <remotelinux/abstractremotelinuxdeploystep.h>
 
 #include <utils/qtcprocess.h>

src/plugins/remotelinux/abstractremotelinuxdeployservice.cpp

@@ -24,6 +24,7 @@
 ****************************************************************************/
 
 #include "abstractremotelinuxdeployservice.h"
+
 #include "deploymenttimeinfo.h"
 
 #include <projectexplorer/deployablefile.h>

src/plugins/remotelinux/abstractremotelinuxdeploystep.cpp

@@ -26,7 +26,6 @@
 #include "abstractremotelinuxdeploystep.h"
 
 #include "abstractremotelinuxdeployservice.h"
-#include "remotelinuxdeployconfiguration.h"
 
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/kitinformation.h>

src/plugins/remotelinux/abstractremotelinuxdeploystep.h

@@ -27,12 +27,13 @@
 
 #include "remotelinux_export.h"
 
-#include "abstractremotelinuxdeployservice.h"
-
 #include <projectexplorer/buildstep.h>
 
 namespace RemoteLinux {
 
+class AbstractRemoteLinuxDeployService;
+class CheckResult;
+
 namespace Internal { class AbstractRemoteLinuxDeployStepPrivate; }
 
 class REMOTELINUX_EXPORT AbstractRemoteLinuxDeployStep : public ProjectExplorer::BuildStep

src/plugins/remotelinux/checkforfreediskspacestep.h

@@ -25,6 +25,8 @@
 
 #pragma once
 
+#include "remotelinux_export.h"
+
 #include "abstractremotelinuxdeploystep.h"
 
 namespace RemoteLinux {

src/plugins/remotelinux/customcommanddeploystep.cpp

@@ -25,6 +25,7 @@
 
 #include "customcommanddeploystep.h"
 
+#include "abstractremotelinuxdeployservice.h"
 #include "remotelinux_constants.h"
 
 #include <projectexplorer/devicesupport/idevice.h>

src/plugins/remotelinux/customcommanddeploystep.h

@@ -25,6 +25,8 @@
 
 #pragma once
 
+#include "remotelinux_export.h"
+
 #include "abstractremotelinuxdeploystep.h"
 
 namespace RemoteLinux {

src/plugins/remotelinux/deploymenttimeinfo.h

@@ -27,6 +27,10 @@
 
 #include <QVariantMap>
 
+QT_BEGIN_NAMESPACE
+class QDateTime;
+QT_END_NAMESPACE
+
 namespace ProjectExplorer {
 class DeployableFile;
 class Kit;

src/plugins/remotelinux/filesystemaccess_test.h

@@ -27,8 +27,6 @@
 
 #include <projectexplorer/devicesupport/idevicefactory.h>
 
-#include <utils/fileutils.h>
-
 namespace RemoteLinux {
 namespace Internal {
 

src/plugins/remotelinux/genericdirectuploadservice.h

@@ -25,13 +25,16 @@
 
 #pragma once
 
-#include "abstractremotelinuxdeployservice.h"
 #include "remotelinux_export.h"
 
+#include "abstractremotelinuxdeployservice.h"
+
 #include <QList>
 
-QT_FORWARD_DECLARE_CLASS(QDateTime)
-QT_FORWARD_DECLARE_CLASS(QString)
+QT_BEGIN_NAMESPACE
+class QDateTime;
+class QString;
+QT_END_NAMESPACE
 
 namespace ProjectExplorer { class DeployableFile; }
 namespace Utils { class QtcProcess; }

src/plugins/remotelinux/genericdirectuploadstep.h

@@ -25,9 +25,10 @@
 
 #pragma once
 
-#include "abstractremotelinuxdeploystep.h"
 #include "remotelinux_export.h"
 
+#include "abstractremotelinuxdeploystep.h"
+
 namespace RemoteLinux {
 
 class REMOTELINUX_EXPORT GenericDirectUploadStep : public AbstractRemoteLinuxDeployStep

src/plugins/remotelinux/genericlinuxdeviceconfigurationwidget.h

@@ -25,10 +25,10 @@
 
 #pragma once
 
-#include <projectexplorer/devicesupport/idevicewidget.h>
-
 #include "remotelinux_export.h"
 
+#include <projectexplorer/devicesupport/idevicewidget.h>
+
 namespace Utils { class FilePath; }
 
 namespace RemoteLinux {

src/plugins/remotelinux/genericlinuxdeviceconfigurationwizardpages.h

@@ -25,9 +25,10 @@
 
 #pragma once
 
-#include "linuxdevice.h"
 #include "remotelinux_export.h"
 
+#include "linuxdevice.h"
+
 #include <QWizardPage>
 
 namespace RemoteLinux {

src/plugins/remotelinux/killappstep.cpp

@@ -25,6 +25,7 @@
 
 #include "killappstep.h"
 
+#include "abstractremotelinuxdeployservice.h"
 #include "remotelinux_constants.h"
 
 #include <projectexplorer/devicesupport/idevice.h>

src/plugins/remotelinux/killappstep.h

@@ -25,6 +25,8 @@
 
 #pragma once
 
+#include "remotelinux_export.h"
+
 #include "abstractremotelinuxdeploystep.h"
 
 namespace RemoteLinux {

src/plugins/remotelinux/linuxdevicetester.h

@@ -27,9 +27,9 @@
 
 #include "remotelinux_export.h"
 
-#include <projectexplorer/devicesupport/filetransferinterface.h>
 #include <projectexplorer/devicesupport/idevice.h>
 
+namespace ProjectExplorer { enum class FileTransferMethod; }
 namespace Utils { class ProcessResultData; }
 
 namespace RemoteLinux {

src/plugins/remotelinux/remotelinuxdeployconfiguration.h

@@ -25,9 +25,6 @@
 
 #pragma once
 
-#include "remotelinux_export.h"
-
-#include <projectexplorer/buildsteplist.h>
 #include <projectexplorer/deployconfiguration.h>
 
 namespace RemoteLinux {

src/plugins/remotelinux/remotelinuxenvironmentaspectwidget.cpp

@@ -26,7 +26,7 @@
 #include "remotelinuxenvironmentaspectwidget.h"
 
 #include "linuxdevice.h"
-#include "remotelinuxrunconfiguration.h"
+#include "remotelinuxenvironmentaspect.h"
 #include "remotelinuxenvironmentreader.h"
 
 #include <coreplugin/icore.h>

src/plugins/remotelinux/remotelinuxenvironmentaspectwidget.h

@@ -25,14 +25,16 @@
 
 #pragma once
 
-#include "remotelinuxenvironmentaspect.h"
-
 #include <projectexplorer/environmentaspectwidget.h>
 
-QT_FORWARD_DECLARE_CLASS(QPushButton)
+QT_BEGIN_NAMESPACE
+class QPushButton;
+QT_END_NAMESPACE
 
 namespace RemoteLinux {
 
+class RemoteLinuxEnvironmentAspect;
+
 namespace Internal { class RemoteLinuxEnvironmentReader; }
 
 class RemoteLinuxEnvironmentAspectWidget : public ProjectExplorer::EnvironmentAspectWidget

src/plugins/remotelinux/remotelinuxrunconfiguration.h

@@ -25,8 +25,6 @@
 
 #pragma once
 
-#include "remotelinux_export.h"
-
 #include <projectexplorer/runconfiguration.h>
 
 namespace RemoteLinux {

src/plugins/remotelinux/rsyncdeploystep.h

@@ -25,9 +25,10 @@
 
 #pragma once
 
-#include "abstractremotelinuxdeploystep.h"
 #include "remotelinux_export.h"
 
+#include "abstractremotelinuxdeploystep.h"
+
 namespace RemoteLinux {
 
 class REMOTELINUX_EXPORT RsyncDeployStep : public AbstractRemoteLinuxDeployStep

src/plugins/remotelinux/sshkeycreationdialog.h

@@ -25,12 +25,10 @@
 
 #pragma once
 
-#include "remotelinux_export.h"
-
-#include <utils/filepath.h>
-
 #include <QDialog>
 
+namespace Utils { class FilePath; }
+
 namespace RemoteLinux {
 
 namespace Ui { class SshKeyCreationDialog; }

src/plugins/remotelinux/tarpackagecreationstep.h

@@ -25,13 +25,12 @@
 
 #pragma once
 
-#include "abstractpackagingstep.h"
-#include "deploymenttimeinfo.h"
 #include "remotelinux_export.h"
 
-#include <projectexplorer/deployablefile.h>
+#include "abstractpackagingstep.h"
+#include "deploymenttimeinfo.h"
 
-#include <utils/aspects.h>
+#include <projectexplorer/deployablefile.h>
 
 QT_BEGIN_NAMESPACE
 class QFile;

src/plugins/remotelinux/tarpackagedeploystep.cpp

@@ -25,6 +25,7 @@
 
 #include "tarpackagedeploystep.h"
 
+#include "abstractremotelinuxdeployservice.h"
 #include "remotelinux_constants.h"
 #include "tarpackagecreationstep.h"