Android: Move AndroidToolChain::suggestedGdbServer to only user

Less code and casting.

Change-Id: I43e1b9f90b39a50b2fb4c35fadeb1b244dbe9930
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>

src/plugins/android/androidgdbserverkitinformation.cpp

@@ -26,6 +26,7 @@
 #include "androidgdbserverkitinformation.h"
 #include "androidconstants.h"
 #include "androidtoolchain.h"
+#include "androidconfigurations.h"
 
 #include <utils/pathchooser.h>
 #include <utils/elidinglabel.h>
@@ -129,8 +130,7 @@ FilePath AndroidGdbServerKitAspect::autoDetect(const Kit *kit)
     ToolChain *tc = ToolChainKitAspect::toolChain(kit, ProjectExplorer::Constants::CXX_LANGUAGE_ID);
     if (!tc || tc->typeId() != Constants::ANDROID_TOOLCHAIN_TYPEID)
         return FilePath();
-    auto atc = static_cast<AndroidToolChain *>(tc);
-    return atc->suggestedGdbServer();
+    return AndroidConfigurations::currentConfig().gdbServer(tc->targetAbi());
 }
 
 ///////////////

src/plugins/android/androidtoolchain.cpp

@@ -105,11 +105,6 @@ void AndroidToolChain::addToEnvironment(Environment &env) const
             AndroidConfigurations::currentConfig().sdkLocation().toString());
 }
 
-FilePath AndroidToolChain::suggestedGdbServer() const
-{
-    return AndroidConfigurations::currentConfig().gdbServer(targetAbi());
-}
-
 bool AndroidToolChain::fromMap(const QVariantMap &data)
 {
     if (!ClangToolChain::fromMap(data))

src/plugins/android/androidtoolchain.h

@@ -41,7 +41,6 @@ public:
     bool isValid() const override;
     void addToEnvironment(Utils::Environment &env) const override;
 
-    Utils::FilePath suggestedGdbServer() const;
     QStringList suggestedMkspecList() const override;
     Utils::FilePath makeCommand(const Utils::Environment &environment) const override;
     bool fromMap(const QVariantMap &data) override;