feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify IBuildConfigurationFactory interface

Browse Source 
Following the RunConfigurationFactory lead this replaces
f = Foo::find(); f->do() by static Foo::do() stanzas.

Also de-virtualize/private-ize IBuildConfigurationFactory::canCreate()
as it is only a local helper nowadays.

Change-Id: Id36ba514f426ebd054592189aa29c170ba00d92f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-03-12 10:11:10 +01:00
parent bfdcbf861f
commit 66d18ce07f
4 changed files with 29 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/project.cpp
View File

@@ -358,12 +358,7 @@ bool Project::copySteps(Target *sourceTarget, Target *newTarget)
QStringList runconfigurationError;
foreach (BuildConfiguration *sourceBc, sourceTarget->buildConfigurations()) {
IBuildConfigurationFactory *factory = IBuildConfigurationFactory::find(newTarget, sourceBc);
if (!factory) {
buildconfigurationError << sourceBc->displayName();
continue;
}
BuildConfiguration *newBc = factory->clone(newTarget, sourceBc);
BuildConfiguration *newBc = IBuildConfigurationFactory::clone(newTarget, sourceBc);
if (!newBc) {
buildconfigurationError << sourceBc->displayName();
continue;