feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify IBuildConfigurationFactory interface

Browse Source 
Following the RunConfigurationFactory lead this replaces
f = Foo::find(); f->do() by static Foo::do() stanzas.

Also de-virtualize/private-ize IBuildConfigurationFactory::canCreate()
as it is only a local helper nowadays.

Change-Id: Id36ba514f426ebd054592189aa29c170ba00d92f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-03-12 10:11:10 +01:00
parent bfdcbf861f
commit 66d18ce07f
4 changed files with 29 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/projectexplorer/target.cpp
View File

@@ -741,14 +741,9 @@ bool Target::fromMap(const QVariantMap &map)
if (!map.contains(key))
return false;
const QVariantMap valueMap = map.value(key).toMap();
IBuildConfigurationFactory *factory = IBuildConfigurationFactory::find(this, valueMap);
if (!factory) {
qWarning("No factory found to restore build configuration!");
continue;
}
BuildConfiguration *bc = factory->restore(this, valueMap);
BuildConfiguration *bc = IBuildConfigurationFactory::restore(this, valueMap);
if (!bc) {
qWarning("Failed '%s' to restore build configuration!", qPrintable(factory->objectName()));
qWarning("No factory found to restore build configuration!");
continue;
}
QTC_CHECK(bc->id() == ProjectExplorer::idFromMap(valueMap));