feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: Ie9594bf661dbeecf22589c1580648252f0bfb7fb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-05-17 10:31:15 +02:00
parent a2797ec80e
commit 66f132dd9b
14 changed files with 65 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/texteditor/findinfiles.cpp
View File

@@ -159,7 +159,8 @@ QWidget *FindInFiles::createConfigWidget()
gridLayout->addWidget(m_searchEngineCombo, row, 1);
m_searchEngineWidget = new QStackedWidget(m_configWidget);
foreach (SearchEngine *searchEngine, searchEngines()) {
const QVector<SearchEngine *> searchEngineVector = searchEngines();
for (const SearchEngine *searchEngine : searchEngineVector) {
m_searchEngineWidget->addWidget(searchEngine->widget());
m_searchEngineCombo->addItem(searchEngine->title());
}
@@ -197,7 +198,7 @@ QWidget *FindInFiles::createConfigWidget()
setValid(currentSearchEngine()->isEnabled() && m_directory->isValid());
};
connect(this, &BaseFileFind::currentSearchEngineChanged, this, updateValidity);
foreach (SearchEngine *searchEngine, searchEngines())
for (const SearchEngine *searchEngine : searchEngineVector)
connect(searchEngine, &SearchEngine::enabledChanged, this, updateValidity);
connect(m_directory.data(), &PathChooser::validChanged, this, updateValidity);
updateValidity();