feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: Ie9594bf661dbeecf22589c1580648252f0bfb7fb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-05-17 10:31:15 +02:00
parent a2797ec80e
commit 66f132dd9b
14 changed files with 65 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/texteditor/textmark.cpp
View File

@@ -472,7 +472,8 @@ void TextMarkRegistry::editorOpened(IEditor *editor)
if (!m_marks.contains(document->filePath()))
return;
foreach (TextMark *mark, m_marks.value(document->filePath()))
const QSet<TextMark *> marks = m_marks.value(document->filePath());
for (TextMark *mark : marks)
document->addMark(mark);
}
@@ -487,13 +488,14 @@ void TextMarkRegistry::documentRenamed(IDocument *document,
return;
QSet<TextMark *> toBeMoved;
foreach (TextMark *mark, baseTextDocument->marks())
const QList<TextMark *> marks = baseTextDocument->marks();
for (TextMark *mark : marks)
toBeMoved.insert(mark);
m_marks[oldPath].subtract(toBeMoved);
m_marks[newPath].unite(toBeMoved);
foreach (TextMark *mark, toBeMoved)
for (TextMark *mark : qAsConst(toBeMoved))
mark->updateFileName(newPath);
}
@@ -502,12 +504,12 @@ void TextMarkRegistry::allDocumentsRenamed(const FilePath &oldPath, const FilePa
if (!m_marks.contains(oldPath))
return;
QSet<TextMark *> oldFileNameMarks = m_marks.value(oldPath);
const QSet<TextMark *> oldFileNameMarks = m_marks.value(oldPath);
m_marks[newPath].unite(oldFileNameMarks);
m_marks[oldPath].clear();
foreach (TextMark *mark, oldFileNameMarks)
for (TextMark *mark : oldFileNameMarks)
mark->updateFileName(newPath);
}