feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

qmake: QmakeParserPriFileNode: Use unique_ptr

Browse Source 
Use unique_ptr to hold the QmakePriFileDocument. That makes
it clearer that QmakePriFileNode owns it.

Change-Id: Ia31778ad2a9d33a13cf818d3bcad0485ebfa2043
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
This commit is contained in:
Tobias Hunger
2017-02-09 15:09:25 +01:00
parent e376424b33
commit 671e1626da
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
View File

@@ -460,8 +460,8 @@ QmakeParserPriFileNode::QmakeParserPriFileNode(QmakeProject *project,
m_projectDir(filePath.toFileInfo().absolutePath())
{
Q_ASSERT(project);
m_priFileDocument = new QmakePriFileDocument(this);
Core::DocumentManager::addDocument(m_priFileDocument);
m_priFileDocument = std::make_unique<QmakePriFileDocument>(this);
Core::DocumentManager::addDocument(m_priFileDocument.get());
setDisplayName(filePath.toFileInfo().completeBaseName());
setIcon(qmakeParserNodeStaticData()->projectIcon);
@@ -470,7 +470,6 @@ QmakeParserPriFileNode::QmakeParserPriFileNode(QmakeProject *project,
QmakeParserPriFileNode::~QmakeParserPriFileNode()
{
watchFolders(QSet<QString>());
delete m_priFileDocument;
}
void QmakeParserPriFileNode::scheduleUpdate()