feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

OutputParser: Parsers with fatal errors will now cause failure for all steps

Browse Source 
Remove handling of parsers reporting fatal errors from the qmake based
makestep and add it to abstractprocessstep instead. This makes the
osparser work with all build systems.

Change-Id: I1044d0e6002d2157946e0342fe060991ffe37ffa
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Tobias Hunger
2013-08-21 11:40:00 +02:00
parent 5a916fb695
commit 672fc59fd6
3 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/qt4projectmanager/makestep.cpp
View File

@@ -298,15 +298,6 @@ void MakeStep::run(QFutureInterface<bool> & fi)
AbstractProcessStep::run(fi);
}
bool MakeStep::processSucceeded(int exitCode, QProcess::ExitStatus status)
{
// Symbian does retun 0, even on failed makes! So we check for fatal make errors here.
if (outputParser() && outputParser()->hasFatalErrors())
return false;
return AbstractProcessStep::processSucceeded(exitCode, status);
}
bool MakeStep::immutable() const
{
return false;