feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: Move a few factories to their product's compilation units

Browse Source 
There's several hundred kBytes extra for the separate .o in a
debug build, this doesn't scale well for a handful lines of code.

As the Nim plugin is a nice template for others elsewise, it would
be nice to use scalable patterns only.

Change-Id: I78e473d28a6a63d458dcbe06a77d93221867417f
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2018-01-17 19:05:42 +01:00
parent 8320ae06f7
commit 673aacc67c
15 changed files with 55 additions and 278 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/nim/project/nimcompilercleanstep.cpp
View File

@@ -29,6 +29,7 @@
#include "../nimconstants.h"
#include <projectexplorer/projectexplorerconstants.h>
#include <utils/qtcassert.h>
#include <QDir>
@@ -107,5 +108,16 @@ bool NimCompilerCleanStep::removeOutFilePath()
return QFile(bc->outFilePath().toFileInfo().absoluteFilePath()).remove();
}
// NimCompilerCleanStepFactory
NimCompilerCleanStepFactory::NimCompilerCleanStepFactory()
{
registerStep<NimCompilerCleanStep>(Constants::C_NIMCOMPILERCLEANSTEP_ID);
setFlags(BuildStepInfo::Unclonable);
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN);
setSupportedConfiguration(Constants::C_NIMBUILDCONFIGURATION_ID);
setRepeatable(false);
setDisplayName(tr(Nim::Constants::C_NIMCOMPILERCLEANSTEP_DISPLAY));
}
} // Nim