From 67408ac1830a3d2493273cd74fe2941b38ba4b87 Mon Sep 17 00:00:00 2001
From: Knud Dollereder <knud.dollereder@qt.io>
Date: Tue, 2 Aug 2022 16:03:06 +0200
Subject: [PATCH] Add tooltips to the timeline settings dialog

Using the suggestions from the bugreport.

Fixes: QDS-7109
Change-Id: Iedf991958525d793f89e3d591f978a19d53a39bd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 .../timelineeditor/timelineanimationform.ui   | 27 +++++++++++++++++++
 .../components/timelineeditor/timelineform.ui | 15 +++++++++++
 2 files changed, 42 insertions(+)

diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelineanimationform.ui b/src/plugins/qmldesigner/components/timelineeditor/timelineanimationform.ui
index f24da6edf99..3329d30af66 100644
--- a/src/plugins/qmldesigner/components/timelineeditor/timelineanimationform.ui
+++ b/src/plugins/qmldesigner/components/timelineeditor/timelineanimationform.ui
@@ -13,6 +13,9 @@
   <layout class="QGridLayout" name="gridLayout">
    <item row="4" column="3">
     <widget class="QLabel" name="label_16">
+     <property name="toolTip">
+      <string>Number of times the animation runs before it stops.</string>
+     </property>
      <property name="text">
       <string>Loops:</string>
      </property>
@@ -49,6 +52,9 @@
    </item>
    <item row="4" column="1">
     <widget class="QLabel" name="label_15">
+     <property name="toolTip">
+      <string>Sets the animation to loop indefinitely.</string>
+     </property>
      <property name="text">
       <string>Continuous</string>
      </property>
@@ -113,6 +119,9 @@
        <height>0</height>
       </size>
      </property>
+     <property name="toolTip">
+      <string>Name for the animation.</string>
+     </property>
      <property name="text">
       <string>Animation ID:</string>
      </property>
@@ -158,6 +167,9 @@
    </item>
    <item row="5" column="1">
     <widget class="QLabel" name="label_23">
+     <property name="toolTip">
+      <string>State to activate when the animation finishes.</string>
+     </property>
      <property name="text">
       <string>Finished:</string>
      </property>
@@ -165,6 +177,9 @@
    </item>
    <item row="4" column="7">
     <widget class="QLabel" name="label_17">
+     <property name="toolTip">
+      <string>Runs the animation backwards to the beginning when it reaches the end.</string>
+     </property>
      <property name="text">
       <string>Ping pong</string>
      </property>
@@ -218,6 +233,9 @@
      <property name="enabled">
       <bool>true</bool>
      </property>
+     <property name="toolTip">
+      <string>Runs the animation automatically when the base state is active.</string>
+     </property>
      <property name="text">
       <string>Running in base state</string>
      </property>
@@ -253,6 +271,9 @@
    </item>
    <item row="3" column="1">
     <widget class="QLabel" name="label_12">
+     <property name="toolTip">
+      <string>First frame of the animation.</string>
+     </property>
      <property name="text">
       <string>Start frame:</string>
      </property>
@@ -286,6 +307,9 @@
    </item>
    <item row="3" column="7">
     <widget class="QLabel" name="label_14">
+     <property name="toolTip">
+      <string>Length of the animation in milliseconds. If you set a shorter duration than the number of frames, frames are left out from the end of the animation.</string>
+     </property>
      <property name="text">
       <string>Duration:</string>
      </property>
@@ -293,6 +317,9 @@
    </item>
    <item row="3" column="3">
     <widget class="QLabel" name="label_13">
+     <property name="toolTip">
+      <string>Last frame of the animation.</string>
+     </property>
      <property name="text">
       <string>End frame:</string>
      </property>
diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelineform.ui b/src/plugins/qmldesigner/components/timelineeditor/timelineform.ui
index 370a6f8154c..53877b5695e 100644
--- a/src/plugins/qmldesigner/components/timelineeditor/timelineform.ui
+++ b/src/plugins/qmldesigner/components/timelineeditor/timelineform.ui
@@ -42,6 +42,9 @@
    </item>
    <item row="2" column="4">
     <widget class="QLabel" name="label_7">
+     <property name="toolTip">
+      <string>Last frame of the timeline.</string>
+     </property>
      <property name="text">
       <string>End frame:</string>
      </property>
@@ -52,6 +55,9 @@
    </item>
    <item row="2" column="1">
     <widget class="QLabel" name="label_6">
+     <property name="toolTip">
+      <string>First frame of the timeline. Negative numbers are allowed.</string>
+     </property>
      <property name="text">
       <string>Start frame:</string>
      </property>
@@ -87,6 +93,9 @@
      <property name="enabled">
       <bool>false</bool>
      </property>
+     <property name="toolTip">
+      <string>To create an expression binding animation, delete all animations from this timeline.</string>
+     </property>
      <property name="text">
       <string>Expression binding</string>
      </property>
@@ -94,6 +103,9 @@
    </item>
    <item row="1" column="0">
     <widget class="QLabel" name="label_5">
+     <property name="toolTip">
+      <string>Name for the timeline.</string>
+     </property>
      <property name="text">
       <string>Timeline ID:</string>
      </property>
@@ -152,6 +164,9 @@
    </item>
    <item row="4" column="0">
     <widget class="QLabel" name="label_8">
+     <property name="toolTip">
+      <string>Sets the expression to bind the current keyframe to.</string>
+     </property>
      <property name="text">
       <string>Expression binding:</string>
      </property>