feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FunctionDeclDefLinkFinder: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I41b753f52d06bb35988d1a57478e06daaec04f31
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-03 01:31:36 +01:00
parent 2f81936218
commit 6744c1e69c
6 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cppeditor/cppfunctiondecldeflink.h
View File

@@ -3,12 +3,10 @@
#pragma once
#include "cppquickfix.h"
#include "cpprefactoringchanges.h"
#include <QString>
#include <QCoreApplication>
#include <QSharedPointer>
#include <QFutureWatcher>
#include <QTextCursor>
@@ -31,14 +29,14 @@ public:
QTextCursor scannedSelection() const;
signals:
void foundLink(QSharedPointer<FunctionDeclDefLink> link);
void foundLink(std::shared_ptr<FunctionDeclDefLink> link);
private:
void onFutureDone();
QTextCursor m_scannedSelection;
QTextCursor m_nameSelection;
QScopedPointer<QFutureWatcher<QSharedPointer<FunctionDeclDefLink> > > m_watcher;
QScopedPointer<QFutureWatcher<std::shared_ptr<FunctionDeclDefLink>>> m_watcher;
};
class FunctionDeclDefLink