feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FunctionDeclDefLinkFinder: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I41b753f52d06bb35988d1a57478e06daaec04f31
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-03 01:31:36 +01:00
parent 2f81936218
commit 6744c1e69c
6 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/cppeditor/cppfunctionparamrenaminghandler.cpp
View File

@@ -6,6 +6,7 @@
#include "cppeditorwidget.h"
#include "cpplocalrenaming.h"
#include "cppfunctiondecldeflink.h"
#include "cppsemanticinfo.h"
#include <cplusplus/AST.h>
#include <cplusplus/ASTPath.h>
@@ -17,7 +18,7 @@ using namespace CPlusPlus;
namespace CppEditor::Internal {
using DeclDefLinkPtr = QSharedPointer<FunctionDeclDefLink>;
using DeclDefLinkPtr = std::shared_ptr<FunctionDeclDefLink>;
class CppFunctionParamRenamingHandler::Private
{
@@ -54,7 +55,7 @@ CppFunctionParamRenamingHandler::Private::Private(
void CppFunctionParamRenamingHandler::Private::handleRenamingStarted()
{
linkFinder.reset();
link.clear();
link.reset();
// Are we currently on the function signature? In this case, the normal decl/def link
// mechanism kicks in and we don't have to do anything.
@@ -78,7 +79,7 @@ void CppFunctionParamRenamingHandler::Private::handleRenamingFinished()
{
if (link) {
link->apply(&editorWidget, false);
link.clear();
link.reset();
}
}