feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Fix memory leak

Browse Source 
Change-Id: Icb0c2a86ee0d5a1e22dc17fbc2a5d155b928e459
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Kandeler
2020-02-06 12:20:23 +01:00
parent 4454873b54
commit 67f66a39be
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/vcsbase/vcsoutputformatter.cpp
View File

@@ -25,21 +25,17 @@
#include <QDesktopServices> #include <QDesktopServices>
#include <QPlainTextEdit> #include <QPlainTextEdit>
#include <QRegularExpression>
#include <QTextCursor> #include <QTextCursor>
#include <QUrl> #include <QUrl>
namespace VcsBase { namespace VcsBase {
VcsOutputFormatter::VcsOutputFormatter() VcsOutputFormatter::VcsOutputFormatter() : m_urlRegexp("https?://\\S*") {}
{
m_urlRegexp = new QRegularExpression("https?://\\S*");
}
void VcsOutputFormatter::appendMessage(const QString &text, Utils::OutputFormat format) void VcsOutputFormatter::appendMessage(const QString &text, Utils::OutputFormat format)
{ {
QString out = text; QString out = text;
const QRegularExpressionMatch match = m_urlRegexp->match(text); const QRegularExpressionMatch match = m_urlRegexp.match(text);
if (match.hasMatch()) { if (match.hasMatch()) {
const QTextCharFormat normalFormat = charFormat(format); const QTextCharFormat normalFormat = charFormat(format);
OutputFormatter::appendMessage(text.left(match.capturedStart()), format); OutputFormatter::appendMessage(text.left(match.capturedStart()), format);

4
src/plugins/vcsbase/vcsoutputformatter.h
View File

@@ -25,7 +25,7 @@
#include <utils/outputformatter.h> #include <utils/outputformatter.h>
QT_FORWARD_DECLARE_CLASS(QRegularExpression); #include <QRegularExpression>
namespace VcsBase { namespace VcsBase {
@@ -38,7 +38,7 @@ public:
void handleLink(const QString &href) override; void handleLink(const QString &href) override;
private: private:
QRegularExpression *m_urlRegexp = nullptr; const QRegularExpression m_urlRegexp;
}; };
} }