feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AppMan: Fix dependencies of RunWorkers during QML Profiling

Browse Source 
Change-Id: Id8a43d31369ae4cf150458dcab4693bf967decec
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Dominik Holland
2024-01-25 16:41:38 +01:00
parent e0088357d0
commit 681f039d79
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qtapplicationmanager/appmanagerruncontrol.cpp
View File

@@ -97,6 +97,7 @@ public:
m_qmlServices(qmlServices) m_qmlServices(qmlServices)
{ {
setId(AppManager::Constants::DEBUG_LAUNCHER_ID); setId(AppManager::Constants::DEBUG_LAUNCHER_ID);
setEssential(true);
connect(&m_launcher, &Process::started, this, &RunWorker::reportStarted); connect(&m_launcher, &Process::started, this, &RunWorker::reportStarted);
connect(&m_launcher, &Process::done, this, &RunWorker::reportStopped); connect(&m_launcher, &Process::done, this, &RunWorker::reportStopped);
@@ -202,8 +203,6 @@ public:
{ {
setId("ApplicationManagerPlugin.Debug.Support"); setId("ApplicationManagerPlugin.Debug.Support");
//setUsePortsGatherer(isCppDebugging(), isQmlDebugging());
m_debuggee = new AppManInferiorRunner(runControl, false, isCppDebugging(), isQmlDebugging(), m_debuggee = new AppManInferiorRunner(runControl, false, isCppDebugging(), isQmlDebugging(),
QmlDebug::QmlDebuggerServices); QmlDebug::QmlDebuggerServices);
@@ -285,6 +284,9 @@ public:
m_worker = runControl->createWorker(QmlDebug::runnerIdForRunMode(runControl->runMode())); m_worker = runControl->createWorker(QmlDebug::runnerIdForRunMode(runControl->runMode()));
m_worker->addStartDependency(this); m_worker->addStartDependency(this);
addStopDependency(m_worker); addStopDependency(m_worker);
// Make sure the QML Profiler is stopped before the appman-controller
m_runner->addStopDependency(m_worker);
} }
private: private: