feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Make BuildStepConfigWidget::displayName a value

Browse Source 
Use BuildStep::displayName() as default.

This probably could be the only possibility, but currently there
are some discrepancies that are kept in this patch to make
the patch mechanical.

Change-Id: I2a1e5c2ff37ad95e25309eb16e07099e42191f60
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-10-12 17:52:09 +02:00
parent 5fc1b5d8e7
commit 683e7aa6cf
35 changed files with 24 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -415,6 +415,8 @@ CMakeBuildStepConfigWidget::CMakeBuildStepConfigWidget(CMakeBuildStep *buildStep
m_toolArguments(new QLineEdit),
m_buildTargetsList(new QListWidget)
{
setDisplayName(tr("Build", "CMakeProjectManager::CMakeBuildStepConfigWidget display name."));
auto fl = new QFormLayout(this);
fl->setMargin(0);
fl->setFieldGrowthPolicy(QFormLayout::ExpandingFieldsGrow);
@@ -470,11 +472,6 @@ void CMakeBuildStepConfigWidget::itemChanged(QListWidgetItem *item)
updateDetails();
}
QString CMakeBuildStepConfigWidget::displayName() const
{
return tr("Build", "CMakeProjectManager::CMakeBuildStepConfigWidget display name.");
}
void CMakeBuildStepConfigWidget::buildTargetsChanged()
{
{

1
src/plugins/cmakeprojectmanager/cmakebuildstep.h
View File

@@ -120,7 +120,6 @@ class CMakeBuildStepConfigWidget : public ProjectExplorer::BuildStepConfigWidget
Q_OBJECT
public:
CMakeBuildStepConfigWidget(CMakeBuildStep *buildStep);
QString displayName() const override;
QString summaryText() const override;
private: