feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Make BuildStepConfigWidget::displayName a value

Browse Source 
Use BuildStep::displayName() as default.

This probably could be the only possibility, but currently there
are some discrepancies that are kept in this patch to make
the patch mechanical.

Change-Id: I2a1e5c2ff37ad95e25309eb16e07099e42191f60
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-10-12 17:52:09 +02:00
parent 5fc1b5d8e7
commit 683e7aa6cf
35 changed files with 24 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qbsprojectmanager/qbsbuildstep.cpp
View File

@@ -69,7 +69,6 @@ public:
QbsBuildStepConfigWidget(QbsBuildStep *step);
~QbsBuildStepConfigWidget() override;
QString summaryText() const override;
QString displayName() const override;
private:
void updateState();
@@ -602,11 +601,6 @@ QString QbsBuildStepConfigWidget::summaryText() const
return m_summary;
}
QString QbsBuildStepConfigWidget::displayName() const
{
return step()->displayName();
}
void QbsBuildStepConfigWidget::updateState()
{
if (!m_ignoreChange) {

5
src/plugins/qbsprojectmanager/qbscleanstep.cpp
View File

@@ -250,11 +250,6 @@ QString QbsCleanStepConfigWidget::summaryText() const
return m_summary;
}
QString QbsCleanStepConfigWidget::displayName() const
{
return m_step->displayName();
}
void QbsCleanStepConfigWidget::updateState()
{
m_ui->dryRunCheckBox->setChecked(m_step->dryRun());

1
src/plugins/qbsprojectmanager/qbscleanstep.h
View File

@@ -97,7 +97,6 @@ public:
QbsCleanStepConfigWidget(QbsCleanStep *step);
~QbsCleanStepConfigWidget() override;
QString summaryText() const override;
QString displayName() const override;
private:
void updateState();

5
src/plugins/qbsprojectmanager/qbsinstallstep.cpp
View File

@@ -288,11 +288,6 @@ QString QbsInstallStepConfigWidget::summaryText() const
return m_summary;
}
QString QbsInstallStepConfigWidget::displayName() const
{
return m_step->displayName();
}
void QbsInstallStepConfigWidget::updateState()
{
if (!m_ignoreChange) {

1
src/plugins/qbsprojectmanager/qbsinstallstep.h
View File

@@ -100,7 +100,6 @@ public:
QbsInstallStepConfigWidget(QbsInstallStep *step);
~QbsInstallStepConfigWidget() override;
QString summaryText() const override;
QString displayName() const override;
private:
void updateState();