From 6842745a68aebc670bd9625328223edc4793f647 Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 30 Sep 2021 16:40:56 +0200 Subject: [PATCH] Debugger: Avoid some repeated file accesses on startup Change-Id: Id0d8458a872519156b859c40762ebc7837ef434b Reviewed-by: Christian Stenger --- src/plugins/debugger/debuggerkitinformation.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/debugger/debuggerkitinformation.cpp b/src/plugins/debugger/debuggerkitinformation.cpp index edc355469de..e7f1c5f2d7f 100644 --- a/src/plugins/debugger/debuggerkitinformation.cpp +++ b/src/plugins/debugger/debuggerkitinformation.cpp @@ -308,7 +308,8 @@ DebuggerKitAspect::ConfigurationErrors DebuggerKitAspect::configurationErrors(co ConfigurationErrors result = NoConfigurationError; const FilePath debugger = item->command(); - if (!debugger.exists() || debugger.isDir()) + const bool found = debugger.exists() && !debugger.isDir(); + if (!found) result |= DebuggerNotFound; else if (!debugger.isExecutableFile()) result |= DebuggerNotExecutable; @@ -321,7 +322,7 @@ DebuggerKitAspect::ConfigurationErrors DebuggerKitAspect::configurationErrors(co result |= DebuggerDoesNotMatch; } - if (!debugger.exists() || debugger.isDir()) { + if (!found) { if (item->engineType() == NoEngineType) return NoDebugger;